Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test warnings #246

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix unit test warnings #246

merged 2 commits into from
Aug 23, 2023

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Jul 15, 2023

Fixes new warnings in the unit tests:

14>D:\git\OpenCL-CLHPP\tests\test_openclhpp.cpp(1862,50): warning C4312: 'type cast': conversion from 'unsigned int' to 'void *' of greater size

This change follows the existing pattern for converting from a specific bit pattern to a void*.

edit: also fix a few warnings relating to the signature of a few new test functions:

'void (__cdecl *)()' differs in parameter lists from 'UnityTestFunction'

The test functions need to specifically say that their arguments are void.

@bashbaug bashbaug requested a review from Kerilk July 15, 2023 01:06
@bashbaug bashbaug changed the title fix conversion warnings fix unit test warnings Jul 15, 2023
@bashbaug bashbaug merged commit db2b227 into KhronosGroup:main Aug 23, 2023
56 checks passed
@bashbaug bashbaug deleted the fix-warnings branch August 23, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants