Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming Inconsistency for Extension Objects #233

Open
bashbaug opened this issue May 11, 2023 · 3 comments
Open

Naming Inconsistency for Extension Objects #233

bashbaug opened this issue May 11, 2023 · 3 comments
Labels
mobica-program Related to the Mobica Program

Comments

@bashbaug
Copy link
Contributor

We currently have a naming inconsistency for command buffer and semaphore extension objects:

#ifdef cl_khr_semaphore
    class Semaphore;
#endif
#if defined(cl_khr_command_buffer)
    class CommandBufferKhr;
    class MutableCommandKhr;
#endif // cl_khr_command_buffer

Note the Khr suffix on CommandBuffer and MutableCommand objects but not on Semaphore objects.

Do we want a Khr suffix on these objects, at least while they are extension objects?

If we want some sort of decoration while these are extension objects is a suffix the best mechanism? We could consider a namespace instead, for example cl::khr::CommandBuffer.

@aharon-abramson
Copy link

Yes, I prefer the namespace idea.

@Bogumil-Sapinski-Mobica
Copy link
Contributor

!assign

@neiltrevett neiltrevett added the mobica-program Related to the Mobica Program label Jun 27, 2023
@bashbaug
Copy link
Contributor Author

Discussed in the July 11th special teleconference. We prefer the namespace idea, if this will work.

We should give thought how the C++ bindings would change if any of these objects became core features sometime in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobica-program Related to the Mobica Program
Projects
None yet
Development

No branches or pull requests

4 participants