Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mPACKn formats #858

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

aqnuep
Copy link
Collaborator

@aqnuep aqnuep commented Feb 11, 2024

Fixes #857. It also fixes the part of #853 that is related to the changes about mPACKn rules.

Both of these affected the 16X4 and 10X6 formats, so they were addressed together.

Copy link
Collaborator

@MarkCallow MarkCallow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions and minor requests for comments.

tools/imageio/image.hpp Show resolved Hide resolved
tools/imageio/image.hpp Show resolved Hide resolved
lib/vk_format.h Outdated Show resolved Hide resolved
@aqnuep aqnuep marked this pull request as ready for review February 12, 2024 11:50
@MarkCallow MarkCallow merged commit dacd993 into KhronosGroup:main Feb 13, 2024
15 checks passed
@MarkCallow MarkCallow mentioned this pull request Feb 13, 2024
4 tasks
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 21, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the
changes about `mPACKn` rules.

Both of these affected the `16X4` and `10X6` formats, so they were
addressed together.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the
changes about `mPACKn` rules.

Both of these affected the `16X4` and `10X6` formats, so they were
addressed together.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the
changes about `mPACKn` rules.

Both of these affected the `16X4` and `10X6` formats, so they were
addressed together.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the
changes about `mPACKn` rules.

Both of these affected the `16X4` and `10X6` formats, so they were
addressed together.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the
changes about `mPACKn` rules.

Both of these affected the `16X4` and `10X6` formats, so they were
addressed together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createDFDPackedPadded creates DFD with bits and padding in the wrong order
2 participants