-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mPACKn formats #858
Merged
Merged
Fix mPACKn formats #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCallow
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions and minor requests for comments.
4 tasks
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the changes about `mPACKn` rules. Both of these affected the `16X4` and `10X6` formats, so they were addressed together.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the changes about `mPACKn` rules. Both of these affected the `16X4` and `10X6` formats, so they were addressed together.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the changes about `mPACKn` rules. Both of these affected the `16X4` and `10X6` formats, so they were addressed together.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the changes about `mPACKn` rules. Both of these affected the `16X4` and `10X6` formats, so they were addressed together.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fixes KhronosGroup#857. It also fixes the part of KhronosGroup#853 that is related to the changes about `mPACKn` rules. Both of these affected the `16X4` and `10X6` formats, so they were addressed together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #857. It also fixes the part of #853 that is related to the changes about
mPACKn
rules.Both of these affected the
16X4
and10X6
formats, so they were addressed together.