-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent warning if VK_NO_PROTOTYPES is already defined #855
Conversation
@jherico how come you encountered this? |
The Vulkan-Sample uses KTX as a git submodule and incorporates the build directly into it's top level project, so any upstream warnings show up as part of the build of that project. |
But where did the other definition of VK_NO_PROTOTYPES come from that was visible when libktx was being compiled? When you say "build directly" do you mean Vukan-Sample is including the libktx sources directly and setting up its own compile commands? |
It incorporates the CMakeLists.txt as a subproject, but prior to that it does globally set this define: https://github.com/KhronosGroup/Vulkan-Samples/blob/main/third_party/CMakeLists.txt#L50 |
Thanks for the info. and this fix. |
No description provided.