Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent warning if VK_NO_PROTOTYPES is already defined #855

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jherico
Copy link
Contributor

@jherico jherico commented Feb 7, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024

CLA assistant check
All committers have signed the CLA.

@MarkCallow
Copy link
Collaborator

@jherico how come you encountered this? vk_funcs.h is internal to the library.

@jherico
Copy link
Contributor Author

jherico commented Feb 8, 2024

The Vulkan-Sample uses KTX as a git submodule and incorporates the build directly into it's top level project, so any upstream warnings show up as part of the build of that project.

@MarkCallow
Copy link
Collaborator

The Vulkan-Sample uses KTX as a git submodule and incorporates the build directly into it's top level project, so any upstream warnings show up as part of the build of that project.

But where did the other definition of VK_NO_PROTOTYPES come from that was visible when libktx was being compiled? When you say "build directly" do you mean Vukan-Sample is including the libktx sources directly and setting up its own compile commands?

@jherico
Copy link
Contributor Author

jherico commented Feb 8, 2024

It incorporates the CMakeLists.txt as a subproject, but prior to that it does globally set this define: https://github.com/KhronosGroup/Vulkan-Samples/blob/main/third_party/CMakeLists.txt#L50

@MarkCallow MarkCallow merged commit d2d63f0 into KhronosGroup:main Feb 9, 2024
15 checks passed
@MarkCallow
Copy link
Collaborator

Thanks for the info. and this fix.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 21, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants