Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JNI component and integrate Java build & test with CMake #556

Merged
merged 54 commits into from
Apr 12, 2022

Conversation

MarkCallow
Copy link
Collaborator

@MarkCallow MarkCallow commented Apr 12, 2022

Includes adding jni/jar build to Windows and fixing issues finding libktx on macOS.

The following unrelated work is included:

  • Add KTX logos to the installers as I was working on them.
  • Fix macOS ktx_uninstall script so it removes symlinks and the sole directory created by the installation.
  • Fix handling of command line config variable overrides in ci_scripts/build_win.ps1.
  • Remove errant popd from .appveyor.yml "script" phase.

Handle symlinks in ktx-uninstall.

Code signing is commented out because loadLibrary is failing
when the library is signed.
so that dyld will load the library during build+test without install.
Temporarily disable non-JNI configs to speed up debugging.
@MarkCallow
Copy link
Collaborator Author

@ShukantPal please review.

Copy link
Contributor

@ShukantPal ShukantPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkCallow MarkCallow merged commit e29e099 into master Apr 12, 2022
@MarkCallow MarkCallow deleted the jni-component branch April 12, 2022 08:39
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 21, 2024
…Group#556)

Includes adding jni/jar build to Windows and fixing issues finding libktx on macOS.

The following unrelated work is included:

- Add KTX logos to the installers, as I was working on them.
- Fix macOS ktx_uninstall script so it removes symlinks and the sole directory created by the installation.
- Fix handling of command line config variable overrides in ci_scripts/build_win.ps1.
- Remove errant popd from .appveyor.yml "script" phase.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
…Group#556)

Includes adding jni/jar build to Windows and fixing issues finding libktx on macOS.

The following unrelated work is included:

- Add KTX logos to the installers, as I was working on them.
- Fix macOS ktx_uninstall script so it removes symlinks and the sole directory created by the installation.
- Fix handling of command line config variable overrides in ci_scripts/build_win.ps1.
- Remove errant popd from .appveyor.yml "script" phase.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
…Group#556)

Includes adding jni/jar build to Windows and fixing issues finding libktx on macOS.

The following unrelated work is included:

- Add KTX logos to the installers, as I was working on them.
- Fix macOS ktx_uninstall script so it removes symlinks and the sole directory created by the installation.
- Fix handling of command line config variable overrides in ci_scripts/build_win.ps1.
- Remove errant popd from .appveyor.yml "script" phase.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
…Group#556)

Includes adding jni/jar build to Windows and fixing issues finding libktx on macOS.

The following unrelated work is included:

- Add KTX logos to the installers, as I was working on them.
- Fix macOS ktx_uninstall script so it removes symlinks and the sole directory created by the installation.
- Fix handling of command line config variable overrides in ci_scripts/build_win.ps1.
- Remove errant popd from .appveyor.yml "script" phase.
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
…Group#556)

Includes adding jni/jar build to Windows and fixing issues finding libktx on macOS.

The following unrelated work is included:

- Add KTX logos to the installers, as I was working on them.
- Fix macOS ktx_uninstall script so it removes symlinks and the sole directory created by the installation.
- Fix handling of command line config variable overrides in ci_scripts/build_win.ps1.
- Remove errant popd from .appveyor.yml "script" phase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants