git subrepo pull (merge) lib/astc-encoder

[wasimabbas-arm]

subrepo:
subdir: "lib/astc-encoder"
merged: "adc637b0"
upstream:
origin: "https://github.com/ARM-software/astc-encoder.git"
branch: "main"
commit: "42a8f6ee"
git-subrepo:
version: "0.4.3"
origin: "https://github.com/ingydotnet/git-subrepo"
commit: "2f68596"

[MarkCallow]

Change this to the correct parent of this subrepo pull which is 2b1c072.

[wasimabbas-arm]

done in 7b67ad9

[MarkCallow]

Looks fine but the parent in the .gitrepo file must be fixed. It still shows the parent of the previous subrepo pull.

[MarkCallow]

I just merged this and in doing so saw that a large number of files `astc-encoder/Test/Images///_results.csv have been added. Was this intentional. Why would test results be added to the repo?

I also just tried another git subrepo pull lib /astc-encoder to ensure the squash merge of your PR hadn't broken anything - it hadn't - and was surprised to see it pull another large change from upstream. Do we need this change too? I've removed it from my clone for now.

[wasimabbas-arm]

astc-encoder/Test/Images///_results.csv

These were always there. Just upgraded due to a big change. These are reference scores, used for CI stuff.

Pete has done a lot of changes recently. We could do another upgrade but its an active project. He said:

I fixed a couple of bugs related to handling of error blocks, so probalby worth updating.

[MarkCallow]

I'm still working on issues related to the Basis v1.16.1 pull so upgrading again will not delay the release. Let's do it as Pete recommends it.