Make Hint Editor buttons prettier - #3959
Merged
Merged
Conversation
- Use WB icon buttons for movement buttons - Use WB button for "Add a hint" button - Use WB button for "Remove a hint" button Also updated add/remove hint buttons inside Graded Group widget. Issue: none Test plan: `pnpm jest packages/perseus-editor/src/__tests__/hint-editor.test.tsx` Storybook - `/?path=/story/editors-editorpage--demo`
Contributor
npm SnapshotWant to try this PR's changes before it merges? Comment |
Contributor
|
Size Change: -231 B (-0.04%) Total Size: 516 kB 📦 View Changed
ℹ️ View Unchanged
|
| <button | ||
| type="button" | ||
| className={this.props.isLast ? "hidden" : ""} | ||
| <span |
Contributor
There was a problem hiding this comment.
Nit: Since this is having display: flex applied to it (which is essentially a "block" format), then this should probably be a <div> element instead of a <span>. It's a small semantic thing, and definitely not a blocker.
mark-fitzgerald
approved these changes
Jul 28, 2026
mark-fitzgerald
left a comment
mark-fitzgerald
left a comment
Contributor
There was a problem hiding this comment.
Styling setup looks good. Revised UI for the hints editor looks fabulous! Thank you!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Also updated add/remove hint buttons inside Graded Group widget.
Issue: none
Test plan:
pnpm jest packages/perseus-editor/src/__tests__/hint-editor.test.tsxStorybook
/?path=/story/editors-editorpage--demo