Replace prop-types with TypeScript types in widget editors - #3858
Draft
jeremywiebe wants to merge 28 commits into
Draft
Replace prop-types with TypeScript types in widget editors#3858jeremywiebe wants to merge 28 commits into
jeremywiebe wants to merge 28 commits into
Conversation
Contributor
|
Size Change: -1.01 kB (-0.2%) Total Size: 516 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4c97b2a) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3858If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3858If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3858 |
…pes in widget editors
…-disable from interactive-graph-settings
…es in NumberInput
…es in TextListEditor; narrow options to string[]
…es in SimpleKeypadInput; remove rest-prop spread
…settings to remove defunct id prop
…es in matcher-editor
…es in matrix-editor
…es in measurer-editor
…es in molecule-editor
…es in number-line-editor
…es in numeric-input-editor
…es in orderer-editor
…es in sorter-editor
jeremywiebe
force-pushed
the
claude/stupefied-gates-c80d2e
branch
from
July 9, 2026 20:36
089c430 to
789fde9
Compare
Collaborator
Author
|
/snapshot |
…abels are a 2-element array
jeremywiebe
force-pushed
the
claude/stupefied-gates-c80d2e
branch
from
July 9, 2026 20:41
789fde9 to
dab9f6c
Compare
Collaborator
Author
|
/snapshot |
jeremywiebe
commented
Jul 10, 2026
| <label htmlFor="canvas-size"> | ||
| Canvas size (x,y pixels) | ||
| </label> | ||
| {/* eslint-disable-next-line jsx-a11y/label-has-associated-control -- TODO(LEMS-2871): Address a11y error */} |
Collaborator
Author
There was a problem hiding this comment.
The RangeInput doesn't apply the id prop we pass it to anything. It also provides a start/end label for each input it renders so linking a label here is un-helpful.
Maybe there's a better way to address the labelling a11y issue? Avoid making this a <label>?
…ipt types in molecule-editor
…ipt types in measurer-editor
…ipt types in matrix-editor
…ript types in widget editors
… at editor entry points; thread APIOptionsWithDefaults through editor chain
jeremywiebe
commented
Jul 10, 2026
| render(<Harnessed apiOptions={{editingDisabled: true}} />); | ||
| render( | ||
| <Harnessed | ||
| apiOptions={{...ApiOptions.defaults, editingDisabled: true}} |
Collaborator
Author
There was a problem hiding this comment.
With the removal of prop-types, it's become apparent that we were a bit loose with the types APIOptions vs. APIOptionsWithDefaults.
The Editor now accepts APIOptionsWithDefaults because it's used internally and (should) always be provided APIOptionsWithDefaults.
jeremywiebe
commented
Jul 10, 2026
| onChange={(cat) => { | ||
| // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2. | ||
| this.change("categories", cat); | ||
| this.props.onChange({categories: cat}); |
Collaborator
Author
There was a problem hiding this comment.
this.change() and Changeable are both a pain... this is simpler and clearer!
jeremywiebe
force-pushed
the
claude/stupefied-gates-c80d2e
branch
from
July 10, 2026 23:13
4e55a85 to
25fc506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: LEMS-XXXX
Test plan: