-
Notifications
You must be signed in to change notification settings - Fork 361
[Passage] Deprecate passage-related widgets (passage, passage-ref, passage-ref-target) #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🗄️ Schema Change: Changes Detected
|
🛠️ Item Splitting: Changes Detected
|
|
Size Change: -10.4 kB (-2.08%) Total Size: 489 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (3e7c2e1) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3147If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3147If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3147 |
7ec2040 to
92d0fb2
Compare
| let nextPassageRefId = 1; | ||
| const widgets: Record<string, any> = {}; | ||
|
|
||
| // passage-ref is already deprecated see LEMS-3124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will revisit this in a different PR (if needed) to check if it's safe to remove this. This is also related to the comment in renderer.tsx regarding alwaysUpdate
anakaren-rojas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left a non-blocking question
packages/perseus-core/src/parse-perseus-json/perseus-parsers/widgets-map.ts
Show resolved
Hide resolved
catandthemachines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment for a fix or a potential follow-up bug for some logic. Excited to see this guy gone!! 🥳
packages/perseus/src/widgets/radio/multiple-choice-widget.new.tsx
Outdated
Show resolved
Hide resolved
…ecate passage-related widgets (passage, passage-ref, passage-ref-target)
…assage-related widgets (passage, passage-ref, passage-ref-target)
432fe55 to
3e7c2e1
Compare
|
👆🏼 rebased from latest master (after |


Summary:
Deprecate passage-related widgets (passage, passage-ref, passage-ref-target)
Pre-work related PRs/work:
Things done:
passageand deleted references and css stylespassagedeleted passage related widgets and editors filesTo reviewer:
Issue: LEMS-3124
Test plan: