This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Don't mangle i18n #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order for build_mobile_perseus.py to extract strings all of the translation functions need to start with 'i18n.'. If we rename this boject it won't be able to extract those strings. This PR fixes this by excluding 'i18n' from mangle. The terser config is almost identical to the one in webapp.
I've also replace the circle-ci build to run
yarn testwith a GitHub Actions check that does the same.Issue: FEI-3478
Test plan: