Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Conversation

@k4b7
Copy link
Contributor

@k4b7 k4b7 commented Apr 27, 2021

Summary:

In order for build_mobile_perseus.py to extract strings all of the translation functions need to start with 'i18n.'. If we rename this boject it won't be able to extract those strings. This PR fixes this by excluding 'i18n' from mangle. The terser config is almost identical to the one in webapp.

I've also replace the circle-ci build to run yarn test with a GitHub Actions check that does the same.

Issue: FEI-3478

Test plan:

  • yarn build
  • inspect build/math-input.js, see that 'i18n._()' calls abound
  • yarn link
  • cd ../webapp/services/static
  • yarn link "@khanacademy/math-input"
  • ./content_render/tools/build_mobile_perseus.py
  • see that it completes and that khan/mobile had an updated perseus bundle and template files
  • rebuild and run the iOS app in Xcode, see that exercises load and work correctly

@k4b7 k4b7 self-assigned this Apr 27, 2021
@k4b7 k4b7 requested review from jeresig and lillialexis April 27, 2021 20:44
@k4b7
Copy link
Contributor Author

k4b7 commented Apr 27, 2021

Please ignore the failing CircleCI job.

@k4b7
Copy link
Contributor Author

k4b7 commented Apr 27, 2021

I somehow broke the storybook build that gets deployed to netlify so I'll have to fix that before this can proceed.

@k4b7
Copy link
Contributor Author

k4b7 commented Apr 27, 2021

I see, it's only some of the stories that are broken in storybook.

@k4b7
Copy link
Contributor Author

k4b7 commented Apr 27, 2021

The storybook is an existing issue on http://khan-math-input.netlify.app so I'm going to punt on it for now.

Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for fixing this!

@k4b7 k4b7 merged commit 551f629 into master Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants