Bump flake8 version #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csilvers
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Yay, so much nicer!
But khan-linter is vendored, so you need to run make vendor_deps and add the changed files to your commit. I'm surprised everything passed for you without doing that; your test plan isn't that specific, so it's hard to tell exactly what you did. It would be great to say something more easily reproducible, such as "I ran in and it completed successfully."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The commit referenced for flake8 no longer exists, upgrade to the latest version supported by py2 and py3. Also fixes this issue when running with python3.8
Issue: XXX-XXXX
Test plan:
Run on local (m1 macbook with python3.8 and python2.7