Merged
Conversation
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
… and 3 Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Pam types online fix
There was a problem hiding this comment.
Pull request overview
This PR merges release-1.9.1 to main, primarily addressing a bug fix for PAM types CLI functionality and updating version information.
Changes:
- Version bump from 1.9.0 to 1.9.1 with build date update to 2026-02-04
- Fixed CLI crash issue when attempting to read PAM types as store types
- Enhanced integration manifest support with distinct V2 and V3 structures
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/version/version.go | Version update to 1.9.1 and build date to 2026-02-04 |
| pkg/test_artifacts/integration-manifest-v3.json | Added V3 integration manifest test artifact for PAM provider |
| pkg/test_artifacts/integration-manifest-v2.json | Added V2 integration manifest test artifact for PAM provider |
| cmd/storeTypes.go | Improved error handling for store type formatting with type assertions and validation |
| cmd/pam_test.go | Enhanced test coverage with mock server implementation and integration test separation |
| cmd/pamTypes_test.go | Added comprehensive tests for V2/V3 integration manifests with mock server validation |
| cmd/pamTypes.go | Updated to use V2 manifest type and corrected log message |
| cmd/pam.go | Fixed deprecation message to reference correct command |
| cmd/integration_manifest.go | Split integration manifest into V2 and V3 versions with separate PAM type structures |
| CHANGELOG.md | Added v1.9.1 release notes documenting the PAM types CLI crash fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var deprecatedPamTypesCreateCmd = &cobra.Command{ | ||
| Use: "types-create", | ||
| Deprecated: "use `pam types create`.", | ||
| Deprecated: "use `pam-types create`.", |
There was a problem hiding this comment.
The deprecation message references 'pam-types create', but based on the test updates in pam_test.go (lines 410, 774, 1035, 1088), the new command pattern is 'pam create' (without the hyphen in 'types'). The message should be 'use pam types create.' to match the actual new command structure.
Suggested change
| Deprecated: "use `pam-types create`.", | |
| Deprecated: "use `pam types create`.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge release-1.9 to main - Automated PR