fix: prevent false negative in session health check for recovered sessions#354
Merged
fix: prevent false negative in session health check for recovered sessions#354
Conversation
…red sessions isSessionHealthy() was scanning the entire tmux pane buffer (50 lines) for error patterns, causing sessions that recovered from transient errors to be incorrectly marked as unhealthy. This made recovered sessions invisible in the UI. - Prioritize active prompt detection (CLAUDE_PROMPT_PATTERN) before error checks - Limit error pattern search to last 10 lines instead of full buffer - Remove ineffective 1-second retry in isClaudeRunning() - Narrow regex pattern to ^Error:.*Claude Code (cli-patterns.ts) - Increase polling duration to 30 minutes (response-poller.ts) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isSessionHealthy()が tmux ペインバッファ全体(50行)をスキャンしてエラーパターンを検出していたため、過去のエラーから回復済みのセッションがunhealthyと誤判定され、UIに表示されなくなる問題を修正isClaudeRunning()の効果のないリトライロジックを削除Test plan
feature/294-worktreeセッションがisSessionRunning: Trueとして正しく検出されることを確認🤖 Generated with Claude Code