Skip to content

Default normalization in distances is counterintuitive (or wrong) #670

Open
@mcschmitz

Description

@mcschmitz

Not a real bug, and maybe it's just personal preference, but I feel like the normalization in several distances is counterintuitive.
For example, the documentation for CosineSimilarity, says

This class is equivalent to DotProductSimilarity(normalize_embeddings=True).

Which of course is correct, however, the default DotProductSimilarity itself normalizes the input vectors.

Also, the documentation for the LpDistance says

With default parameters, this is the Euclidean distance.

This is not true as the Euclidean distances performs on unnormalized vectors.

So maybe a bug after all(?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions