fix issue caused by appending to initialized column, rather than sett…

…ing values (jtablesaw#873)
Kerwinooooo · Jan 25, 2021 · 30cc5c7 · 30cc5c7
1 parent 390b56d
commit 30cc5c7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/core/src/main/java/tech/tablesaw/api/BooleanColumn.java b/core/src/main/java/tech/tablesaw/api/BooleanColumn.java
@@ -655,7 +655,7 @@ public DoubleColumn asDoubleColumn() {
     DoubleColumn numberColumn = DoubleColumn.create(this.name(), size());
     ByteArrayList data = data();
     for (int i = 0; i < size(); i++) {
-      numberColumn.append(data.getByte(i));
+      numberColumn.set(i, data.getByte(i));
     }
     return numberColumn;
   }

diff --git a/core/src/test/java/tech/tablesaw/api/BooleanColumnTest.java b/core/src/test/java/tech/tablesaw/api/BooleanColumnTest.java
@@ -53,6 +53,12 @@ public void testAll() {
     assertTrue(filtered.all());
   }
 
+  @Test
+  public void asDoubleColumn() {
+    DoubleColumn doubleColumn = column.asDoubleColumn();
+    assertEquals(column.size(), doubleColumn.size());
+  }
+
   @Test
   public void inRange() {
     assertFalse(column.all());