Fix population advisor food types display #1612
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johannes-callidus
changed the title
|
Dunno but I like clean code so yay? |
Author
|
It's data which maybe could be used in the future for an custom condition f.e. |
Collaborator
|
Yeah but you can remove it. If we need it later, we'll add it again 😉 |
Author
|
Done, this now increases savegame version though. |
Collaborator
|
Ahh, then remove the function but keep the value (and save version)? |
Johannes-callidus
force-pushed
the
fix-advisor-display
branch
from
73da59d to
af9063d
Compare
Author
|
I don't know if you noticed but the change with only removing the functions is done since 27 days. (It was in the force-push so barely noticable). Just to inform you if you missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1608
Should I remove city_resource_food_types_available from the code as it doesn't have any usecase anymore?