Skip to content

Conversation

@UberWaffe
Copy link
Collaborator

@UberWaffe UberWaffe commented Jan 15, 2025

Added event trigger for building caught fire
Added event trigger for building collapse poor maintenance

This allows for events to trigger their checks on events other than the start of a new game month.
Currently added trigger types include: Building catching fire, building being constructed, building deleted by player, etc.

Also adds the concept of 'context'.
For these new types of triggers, this is the type of building that is involved.

I.e. You can do things like fire off an event when the player places a specific type of building.
Or when a specific type of building (or even any type) catches fire.

Should support redoing the tutorials completely with events only.

@crudelios
Copy link
Collaborator

Great idea! I'll have a look when I have the time.

@crudelios
Copy link
Collaborator

Also, if you don't mind I'll just look into this after #1169 is merged.

@UberWaffe
Copy link
Collaborator Author

No problem, I'll rebase once #1169 is merged.

@UberWaffe UberWaffe force-pushed the feature/condition_fire_ruins branch 4 times, most recently from 9be117d to f71a717 Compare February 4, 2025 09:59
@UberWaffe
Copy link
Collaborator Author

@crudelios Rebased, incorporated the condition group and other changes, and tested.
Tested loading of old save games from before condition groups.
Tested loading of old scenarios from before condition groups.
Tested of saving and loading on new version for saves and scenarions.
Tested XML export and import.

@UberWaffe UberWaffe force-pushed the feature/condition_fire_ruins branch from f71a717 to 302c1d0 Compare February 7, 2025 08:04
@UberWaffe
Copy link
Collaborator Author

Rebased after c2c958b (Fix importing of malformed event xml files).

@crudelios
Copy link
Collaborator

Oops, new recent conflict in translation file! Can you fix so I check this please?

Added event trigger for building caught fire
Added event trigger for building collapse poor maintenance
@UberWaffe UberWaffe force-pushed the feature/condition_fire_ruins branch from 302c1d0 to 673162c Compare February 13, 2025 13:40
@UberWaffe
Copy link
Collaborator Author

@crudelios Rebased on latest

@crudelios
Copy link
Collaborator

@UberWaffe This needs a rebase again, and this time I promise I'll have a look.

@Sephirex95
Copy link
Collaborator

If you're able to resolve merge conflicts, I can review and merge - this is in line with the current goals for 4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants