Add CMake functionality to allow a port to modify what LUS uses for CVar names #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Var names. Utilize CMake definitions in LUS code.
briaguya-ai
reviewed
Apr 28, 2024
Malkierian
force-pushed
the
cvar-redefines
branch
from
e481582 to
4a9dc24
Compare
briaguya-ai
approved these changes
Apr 29, 2024
Kenix3
approved these changes
Apr 30, 2024
Malkierian
force-pushed
the
cvar-redefines
branch
from
932bd7f to
0fc0cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes CMake variables and definitions. On LUS's side, the definitions default to what they currently are; no changes without input from a port. They use
set(CACHE)to allow for being lower priority.All a port has to do is implement a custom cmake file that defines the same variables using non-cache
set()so that the variable usage later finds them before looking in the cache for LUS's definitions.EDIT: As a side note, only the prefixes for
gControllersandgAdvancedResolutionare configurable. Their sub-variables remain fixed in LUS.