Windows DPI awareness #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Spodi
force-pushed
the
win-dpi-aware
branch
2 times, most recently
from
d848629 to
974a39d
Compare
Spodi
force-pushed
the
win-dpi-aware
branch
2 times, most recently
from
60b8068 to
9fe0923
Compare
Use a manifest that declares DPI-awareness for the game instead.
Something is wrong with SDLs original implementation of WM_GETDPISCALEDSIZE, so pass it to the default system window procedure. Should fix window scaling when DPI changes.
Merged
Spodi
added a commit
to Spodi/libultraship
that referenced
this pull request
Jul 25, 2024
* Handle WM_DPICHANGED * Don't run as DPI-aware process here. Use a manifest that declares DPI-awareness for the game instead. * Override SDLs window procedure in Windows Something is wrong with SDLs original implementation of WM_GETDPISCALEDSIZE, so pass it to the default system window procedure. Should fix window scaling when DPI changes. * Fix building on non-Windows * Comment some stuff * Remove now unused run_as_dpi_aware()
Kenix3
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Handle WM_DPICHANGED * Don't run as DPI-aware process here. Use a manifest that declares DPI-awareness for the game instead. * Override SDLs window procedure in Windows Something is wrong with SDLs original implementation of WM_GETDPISCALEDSIZE, so pass it to the default system window procedure. Should fix window scaling when DPI changes. * Fix building on non-Windows * Comment some stuff * Remove now unused run_as_dpi_aware()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pushes the responsibility of making the Windows app DPI aware to the port, so we need to change the Windows app manifest on the ports side, to tell Windows that we can handle it.
Therefore also needs SoH PR: HarbourMasters/Shipwright#3270 <- this includes this LUS change for GitHub to generate a test build