Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: #76bug add validation for all input field's #77

Merged
merged 6 commits into from
Sep 12, 2023
Merged

fixes: #76bug add validation for all input field's #77

merged 6 commits into from
Sep 12, 2023

Conversation

love-sonkar
Copy link
Contributor

fixes #76 added validation in all input field's and for the category i use a dropdown selection for better user experiance and for validation.
you

public/validation.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@MayankBansal12 MayankBansal12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make sure all the functions are working properly.
  • After making the changes, make sure the code is not broken or getting affected due to changes. - Also, try to check everything is working by adding a few entries from your end.

public/validation.js Outdated Show resolved Hide resolved
public/validation.js Show resolved Hide resolved
public/validation.js Outdated Show resolved Hide resolved
public/validation.js Outdated Show resolved Hide resolved
public/validation.js Outdated Show resolved Hide resolved
@KendallDoesCoding
Copy link
Owner

@MayankBansal12 are we good to merge?

@love-sonkar
Copy link
Contributor Author

yes we can merge this PR

Copy link
Collaborator

@MayankBansal12 MayankBansal12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need to modify the add categories. Other than that, everything else looks good.

@KendallDoesCoding KendallDoesCoding merged commit 12e7a2c into KendallDoesCoding:master Sep 12, 2023
@KendallDoesCoding
Copy link
Owner

@love-sonkar - thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: No proper validation for adding youtube channel
3 participants