-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrote comments for some of HTML & JS codes #364
wrote comments for some of HTML & JS codes #364
Conversation
β Deploy Preview for mogulchristmas ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the code, will complete the rest as well.
Merge the branch when feasible so then I can close the PR |
What do you mean? You said there is more to add to this PR above?
|
Oh sorry! Yeah yeah. I'm sorry for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some more comments to the project code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments to JavaScript code files.
I've almost finished the issue. Please review the code, and please add me to the project's list of contributors. For comments, I'll also look through additional files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't edit credits/index.html. it may cause some issues.
@harisdev-netizen . I forgot about the credits thing. Many people may be missing. Let me add them too. Thanks for reminding. |
Okay got it. |
@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you! |
I don't think you've done index.html and css files. |
Okay got it. I'm on it. |
And apart from index.html and css files all the rest is great right? |
Yup. |
Thanks for your contribution @harisdev-netizen |
No problem @KendallDoesCoding, I am really enjoying contributing to open-source. |
I hope you have added me to contributors list. |
@harisdev-netizen - adding ur pfp now, will add ur contribution (pr) later. |
@all-contributors please add @harisdev-netizen to the doc. |
I've put up a pull request to add @harisdev-netizen! π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly review the code and merge.
already merged bro |
π οΈ Fixes Issue
Related Issue/Addition to code
π¨βπ» Changes proposed
Type of change
βοΈ Check List (Check all the applicable boxes)
π Note to reviewers
π· Screenshots