Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrote comments for some of HTML & JS codes #364

Conversation

harisdev-netizen
Copy link
Contributor

@harisdev-netizen harisdev-netizen commented Apr 6, 2023

πŸ› οΈ Fixes Issue

Related Issue/Addition to code

  • Issue goes here

πŸ‘¨β€πŸ’» Changes proposed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Original Updated
** original screenshot ** updated screenshot **

@netlify
Copy link

netlify bot commented Apr 6, 2023

βœ… Deploy Preview for mogulchristmas ready!

Name Link
πŸ”¨ Latest commit b423123
πŸ” Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/6431b845a73b760008ff8680
😎 Deploy Preview https://deploy-preview-364--mogulchristmas.netlify.app/ludsocials/podcasts
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor Author

@harisdev-netizen harisdev-netizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the code, will complete the rest as well.

@harisdev-netizen
Copy link
Contributor Author

Merge the branch when feasible so then I can close the PR

@KendallDoesCoding
Copy link
Owner

Merge the branch when feasible so then I can close the PR

What do you mean? You said there is more to add to this PR above?

will complete the rest

@harisdev-netizen
Copy link
Contributor Author

Oh sorry! Yeah yeah. I'm sorry for the inconvenience.

Copy link
Contributor Author

@harisdev-netizen harisdev-netizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some more comments to the project code

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 7, 2023
Copy link
Contributor Author

@harisdev-netizen harisdev-netizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments to JavaScript code files.

@harisdev-netizen
Copy link
Contributor Author

I've almost finished the issue. Please review the code, and please add me to the project's list of contributors. For comments, I'll also look through additional files.

Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit credits/index.html. it may cause some issues.

@KendallDoesCoding
Copy link
Owner

KendallDoesCoding commented Apr 7, 2023

@harisdev-netizen . I forgot about the credits thing. Many people may be missing. Let me add them too. Thanks for reminding.

@harisdev-netizen
Copy link
Contributor Author

Don't edit credits/index.html. it may cause some issues.

Okay got it.

@harisdev-netizen
Copy link
Contributor Author

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

@KendallDoesCoding
Copy link
Owner

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

@harisdev-netizen
Copy link
Contributor Author

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

Okay got it. I'm on it.

@harisdev-netizen
Copy link
Contributor Author

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

And apart from index.html and css files all the rest is great right?

@KendallDoesCoding
Copy link
Owner

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

And apart from index.html and css files all the rest is great right?

Yup.

This was linked to issues Apr 8, 2023
@KendallDoesCoding KendallDoesCoding merged commit afaf08f into KendallDoesCoding:main Apr 8, 2023
@KendallDoesCoding
Copy link
Owner

Thanks for your contribution @harisdev-netizen

@harisdev-netizen
Copy link
Contributor Author

No problem @KendallDoesCoding, I am really enjoying contributing to open-source.

@harisdev-netizen
Copy link
Contributor Author

I hope you have added me to contributors list.

@KendallDoesCoding
Copy link
Owner

@harisdev-netizen - adding ur pfp now, will add ur contribution (pr) later.

@KendallDoesCoding
Copy link
Owner

@all-contributors please add @harisdev-netizen to the doc.

@allcontributors
Copy link
Contributor

@KendallDoesCoding

I've put up a pull request to add @harisdev-netizen! πŸŽ‰

Copy link
Contributor Author

@harisdev-netizen harisdev-netizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review the code and merge.

@KendallDoesCoding
Copy link
Owner

Kindly review the code and merge.

already merged bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comments for functions and classes [DOCS] Write comments
2 participants