Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pause functionality #349

Merged
merged 2 commits into from
Nov 20, 2022

Conversation

vivsh1999
Copy link
Contributor

πŸ› οΈ Fixes Issue

#347

πŸ‘¨β€πŸ’» Changes proposed

  • fixed the pause btn code

Type of change

  • Bug fix (non-breaking change which fixes an issue)

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“· Screenshots

Original Updated
** original screenshot ** updated screenshot **

@netlify
Copy link

netlify bot commented Nov 19, 2022

βœ… Deploy Preview for mogulchristmas ready!

Name Link
πŸ”¨ Latest commit d126243
πŸ” Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/6378fa6f407f3e0009991bfe
😎 Deploy Preview https://deploy-preview-349--mogulchristmas.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we pause and go to the next song, then the time left for song still displays. Even if we change songs in between the time left still remains. This is fine but then there should be a button to allow user to play from where they paused?

Don't worry about the button though, can you make the time left to go once changed to a new song?

@KendallDoesCoding KendallDoesCoding linked an issue Nov 19, 2022 that may be closed by this pull request
2 tasks
@vivsh1999
Copy link
Contributor Author

can you make the time left to go once changed to a new song?

Fixing it

@vivsh1999
Copy link
Contributor Author

@KendallDoesCoding please review now

Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@KendallDoesCoding KendallDoesCoding merged commit 01e36a4 into KendallDoesCoding:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG REPORT]:- Pause button not working.
2 participants