Added default volume feature

[vivsh1999]

🛠️ Fixes Issue

Fixes #311

Related Issue/Addition to code

• Issue goes here

👨‍💻 Changes proposed

• Added youtube iframe API
• Added default volume as 50%
• Fixed loop video logic (it was crooked before)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

✔️ Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• This PR does not contain plagiarized content.
• The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

• changes in index.html page are for adding youtube's iframe api.
• the first think that gets called is onYouTubeIframeAPIReady when it gets initiated.

📷 Screenshots

Original	Updated
** original screenshot	** updated screenshot **

[netlify]

✅ Deploy Preview for mogulchristmas ready!

Name	Link
🔨 Latest commit	7bcabfc
🔍 Latest deploy log	https://app.netlify.com/sites/mogulchristmas/deploys/634d709eae5bbb0009984431
😎 Deploy Preview	https://deploy-preview-340--mogulchristmas.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[vivsh1999]

@KendallDoesCoding this PR adds youtube iframe API which opens doors to more flexible video controls in future

[KendallDoesCoding]

@KendallDoesCoding this PR adds youtube iframe API which opens doors to more flexible video controls in future

So, that's why when we click a song the text and stuff moves down. It's ok if there's no other option to do this, but it's good that it's invisible.

[KendallDoesCoding]

Will review in a bit.

[vivsh1999]

@KendallDoesCoding this PR adds youtube iframe API which opens doors to more flexible video controls in future

So, that's why when we click a song the text and stuff moves down. It's ok if there's no other option to do this, but it's good that it's invisible.

actually that behavior was there earlier too. I have tested and it works as the old one. Also I will suggest creating a issue for adding volume, pause/play, buffer loading controls. Assign this to me please.

[KendallDoesCoding]

actually that behavior was there earlier too.

oh yeah, i didn't realize

[KendallDoesCoding]

Hi, it's still not working.

Unless, I got it wrong. What I believe this is supposed to do is set a standard volume of 50% per song, right?

So, even when the last YouTube video I watched is on mute, this should be 50%, but maybe it doesn't work like that.

[KendallDoesCoding]

Also, I believe that @KlausMikhaelson was assigned to work on this in #311. In future, if you want to work on a issue, please mention in that issue.

By doing this, no-ones time gets wasted, incase I merge your PR and @KlausMikhaelson has already nearly done from his part but not yet opened the PR, get what I mean, right?

Now, that you've opened the PR it's okay though!

[KlausMikhaelson]

uhhh actually as I mentioned earlier @KendallDoesCoding on the issue I was able to fix it by this approach but thought of trying to do it with kind of api that is already present, lol my bad but just make sure to ask before making a pr in future @sharmavivek223

[KendallDoesCoding]

uhhh actually as I mentioned earlier @KendallDoesCoding on the issue I was able to fix it by this approach but thought of trying to do it with kind of api that is already present,

oh ok, i forgot lol. sorry

[KlausMikhaelson]

nw!!!, gotta complete the other issues now asap lol

[vivsh1999]

uhhh actually as I mentioned earlier @KendallDoesCoding on the issue I was able to fix it by this approach but thought of trying to do it with kind of api that is already present, lol my bad but just make sure to ask before making a pr in future @sharmavivek223

sorry about that, I'll keep that in mind.

@KendallDoesCoding this is working as it should be I tried opening a song in youtube and played on mute, then I played the first song from list in a new tab it was played at 50% volume.
Correct me if I missed something.

[KendallDoesCoding]

@KendallDoesCoding this is working as it should be I tried opening a song in youtube and played on mute, then I played the first song from list in a new tab it was played at 50% volume.

Oh, it didn't work for me. But, will try it again maybe this time locally.

[vivsh1999]

@KendallDoesCoding this is working as it should be I tried opening a song in youtube and played on mute, then I played the first song from list in a new tab it was played at 50% volume.

Oh, it didn't work for me. But, will try it again maybe this time locally.

great, just so you know I tried both locally and on generated preview url

[vivsh1999]

Any updates @KendallDoesCoding ?

[KendallDoesCoding]

@KendallDoesCoding this is working as it should be I tried opening a song in youtube and played on mute, then I played the first song from list in a new tab it was played at 50% volume.

Oh, it didn't work for me. But, will try it again maybe this time locally.

It still isn't working for me. Can you share a screen recording with desktop audio so I can see how it deploys for you?

[KendallDoesCoding]

@sharmavivek223 - I request @TechStudent10 or another contributor to review this as it maybe a problem from my end.

Steps to be done:

• Go to YouTube
• Mute a YouTube Video
• Open the deploy preview website
• See if song plays
• If song plays, let us know. If it doesn't, let us know.

[TechStudent10]

Yeah, no. Sorry can't rn.

[TechStudent10]

I'll have to see if I get any free time

[KendallDoesCoding]

Yeah, no. Sorry can't rn.

Hi, It's not involving any coding. Just a reviewing process. It will take barely 1 minute.

[KendallDoesCoding]

Just follow the steps I shared and we're good to go.

[TechStudent10]

Yeah, no. Sorry can't rn.

Hi, It's not involving any coding. Just a reviewing process. It will take barely 1 minute.

I'm free now. I can take a look.

[TechStudent10]

@KendallDoesCoding The music plays after muting the video on my system. Better do more testing though to see if it's a one-off.

My browser is Brave, if you need it.

[KendallDoesCoding]

Ok. Ig it works with some browsers (depending on the settings of the browsers) (extensions of the browser may make this not work at times). I'll merge it, but in the release notes state the above.

…

On Sat, 5 Nov 2022, 3:23 am TechStudent10, ***@***.***> wrote: @KendallDoesCoding <https://github.com/KendallDoesCoding> The music plays after muting the video on my system. Better do more testing though to see if it's a one-off. My browser is Brave, if you need it. — Reply to this email directly, view it on GitHub <#340 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUGJUTJIBYIHM6LO56ABWKLWGWAVZANCNFSM6AAAAAARHFSCDE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[KendallDoesCoding]

Thanks for your contribution @sharmavivek223.