Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grammatical error and added photo to photo gallery. #328

Merged
merged 8 commits into from
Sep 21, 2022

Conversation

mukul314
Copy link
Contributor

🛠️ Fixes Issue

Related Issue/Addition to code

  • Issue goes here

👨‍💻 Changes proposed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Original Updated
** original screenshot ** updated screenshot **

…estion, corrected comments in index.html and styles.css
…ong suggestion, corrected comments in index.html and styles.css"

This reverts commit fc52ef2.
Reverted the wrong changes and kept the correct ones.
	modified:   README.md
	modified:   index.html
	modified:   styles.css
…dded a song suggestion, corrected comments in index.html and styles.css""

This reverts commit f8f7fce.
…ong suggestion, corrected comments in index.html and styles.css"

This reverts commit fc52ef2.
reverting all the way back to starting
@netlify
Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for mogulchristmas ready!

Name Link
🔨 Latest commit 5b111fc
🔍 Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/632ac7748c544b0008a6e63b
😎 Deploy Preview https://deploy-preview-328--mogulchristmas.netlify.app/photo-gallery
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mukul314
Copy link
Contributor Author

Hey kendall !
please close the PR #326 and try merging this one.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

photo-gallery/index.html Show resolved Hide resolved
Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@KendallDoesCoding KendallDoesCoding changed the title Branch2 Fixed grammatical error and added photo to photo gallery. Sep 21, 2022
@KendallDoesCoding KendallDoesCoding merged commit c5d2d12 into KendallDoesCoding:main Sep 21, 2022
@KendallDoesCoding
Copy link
Owner

Thanks for your contribution! Sorry if I caused any inconvenience by making you revert the stuff and redoing it.

@KendallDoesCoding
Copy link
Owner

@all-contributors please add @mukul314 to the doc

@allcontributors
Copy link
Contributor

@KendallDoesCoding

I've put up a pull request to add @mukul314! 🎉

@mukul314
Copy link
Contributor Author

mukul314 commented Sep 21, 2022 via email

@KendallDoesCoding
Copy link
Owner

KendallDoesCoding commented Oct 11, 2022 via email

@mukul314
Copy link
Contributor Author

mukul314 commented Oct 16, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants