Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added media queries and changed span toggle margin error #295

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

frazie
Copy link
Contributor

@frazie frazie commented Jun 14, 2022

πŸ› οΈ Fixes Issue

Fixes #80

Related Issue/Addition to code

-I have added media queries to assist with responsiveness

πŸ‘¨β€πŸ’» Changes proposed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ”οΈ Check List (Check all the applicable boxes)

  • [ x] My code follows the code style of this project.
  • [x ] This PR does not contain plagiarized content.
  • [ x] The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Original Updated
** original screenshot ** updated screenshot **

@netlify
Copy link

netlify bot commented Jun 14, 2022

βœ… Deploy Preview for mogulchristmas ready!

Name Link
πŸ”¨ Latest commit 63ae7c4
πŸ” Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/62a90590d170af0008f056fe
😎 Deploy Preview https://deploy-preview-295--mogulchristmas.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@frazie
Copy link
Contributor Author

frazie commented Jun 14, 2022

I have tried adjusting the button but each time the code breaks disrupting the structure of the page.

Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot for your contribution!

@KendallDoesCoding
Copy link
Owner

I have tried adjusting the button but each time the code breaks disrupting the structure of the page.

This should be fixed when #262 is complete i guess. @aliraza944 is working on that issue.

@KendallDoesCoding KendallDoesCoding merged commit e040311 into KendallDoesCoding:main Jun 15, 2022
@KendallDoesCoding
Copy link
Owner

Thanks for your contribution!

@frazie
Copy link
Contributor Author

frazie commented Jun 15, 2022

Thanks for your contribution!

You are welcome!!!
I'm also interested in assisting in more projects if you need assistance. Feel free to reach out.

@KendallDoesCoding
Copy link
Owner

Thanks for your contribution!

You are welcome!!! I'm also interested in assisting in more projects if you need assistance. Feel free to reach out.

Thanks, what languages do you code?

@frazie
Copy link
Contributor Author

frazie commented Jun 15, 2022

Thanks for your contribution!

You are welcome!!! I'm also interested in assisting in more projects if you need assistance. Feel free to reach out.

Thanks, what languages do you code?

mainly javascript but HTML, CSS are in my docket

@KendallDoesCoding
Copy link
Owner

Thanks for your contribution!

You are welcome!!! I'm also interested in assisting in more projects if you need assistance. Feel free to reach out.

Thanks, what languages do you code?

mainly javascript but HTML, CSS are in my docket

Oh cool.

@KendallDoesCoding
Copy link
Owner

@all-contributors add @frazie to the doc

@allcontributors
Copy link
Contributor

@KendallDoesCoding

I've put up a pull request to add @frazie! πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants