Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Loop song button #187

Closed
KendallDoesCoding opened this issue Jan 30, 2022 · 32 comments · Fixed by #332
Closed

[FEATURE REQUEST] Loop song button #187

KendallDoesCoding opened this issue Jan 30, 2022 · 32 comments · Fixed by #332
Assignees
@aliraza944 @TechStudent10
Labels
enhancement New feature or request help wanted Help is required from contributors. javascript Javascript PR or a Javascript related issue with code. on-hold Currently on-hold with the PR/Issue or waiting for help. 🔢 points: 8 🟧 priority: high 🏁 status: ready for dev
Milestone
To Be Done by 2023

Comments

@KendallDoesCoding
Copy link
Owner

A small button that if tapped will loop the song.

The code that needs to be added to the embed for this to work is loop=1, that's the youtube api code.

@TechStudent11 Please work on this today, if possible otherwise tommrow. Thanks
@TechStudent10
Copy link
Collaborator

TechStudent10 commented Jan 30, 2022 •
edited
Loading

A small button that if tapped will loop the song.

The code that needs to be added to the embed for this to work is loop=1, that's the youtube api code.

@TechStudent11 Please work on this today, if possible otherwise tommrow. Thanks

The thing is, I don't think I loop a specific segment of a video using the YouTube API.

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Jan 30, 2022 •
edited
Loading

A small button that if tapped will loop the song.
The code that needs to be added to the embed for this to work is loop=1, that's the youtube api code.
@TechStudent11 Please work on this today, if possible otherwise tommrow. Thanks

The thing is, I don't think I loop a specific segment of a video using the YouTube API.

Yes, little extra work but all the songs are listed in the playlist right? Can you make a func that if the loop button is pressed it knows what song was played on top and using the title of the song it will loop via the youtube video of that individual song? Or, will that mess up things? If possible, this would be great, otherwise, its not really needed, this was just a idea coz a loop button would be good in the project, if possible.

@KendallDoesCoding KendallDoesCoding changed the title Loop song button [FEATURE REQUEST] Loop song button Jan 30, 2022
@KendallDoesCoding KendallDoesCoding added the enhancement New feature or request label Jan 30, 2022
@TechStudent10
Copy link
Collaborator

TechStudent10 commented Jan 30, 2022 •
edited
Loading

A small button that if tapped will loop the song.
The code that needs to be added to the embed for this to work is loop=1, that's the youtube api code.
@TechStudent11 Please work on this today, if possible otherwise tommrow. Thanks

The thing is, I don't think I loop a specific segment of a video using the YouTube API.

Yes, little extra work but all the songs are listed in the playlist right? Can you make a func that if the loop button is pressed it knows what song was played on top and using the title of the song it will loop via the youtube video of that individual song? Or, will that mess up things? If possible, this would be great, otherwise, its not really needed, this was just a idea coz a loop button would be good in the project, if possible.

When you say a little extra work, you mean a ton of API requesting. Yes, this is possible, and yes I can do it, but it would require a ton of code, debugging and refactoring.

In short, it isn't worth it.

EDIT: Just found this... https://stackoverflow.com/questions/38645329/how-to-play-a-section-of-a-youtube-video-on-a-loop/41036768

So it is possible.

@KendallDoesCoding
Copy link
Owner Author

True.

I found that stackoverflow too, but I didn't understand it lol

@KendallDoesCoding
Copy link
Owner Author

@TechStudent11 So, can you work on this?

@KendallDoesCoding
Copy link
Owner Author

@TechStudent11 Please can you work on this on priority as soon as possible?

@KendallDoesCoding
Copy link
Owner Author

@TechStudent11 Please can you work on this on priority as soon as possible?

Waiting for your reply on this @TechStudent11 ... Thanks

@TechStudent10
Copy link
Collaborator

Tell me where you want the button to be placed and I'll handle the rest.

@KendallDoesCoding
Copy link
Owner Author

Tell me where you want the button to be placed and I'll handle the rest.

After the song has been started playing, a small button can appear above the lyrics button.

@TechStudent10
Copy link
Collaborator

Tell me where you want the button to be placed and I'll handle the rest.

After the song has been started playing, a small button can appear above the lyrics button.

okay

@TechStudent10
Copy link
Collaborator

Okay so I looked at it a bit more, and this is going to require basically a full rewrite. I think we should hold off on this feature until the React/Next rewrite (#189) is complete.

@KendallDoesCoding
Copy link
Owner Author

Okay so I looked at it a bit more, and this is going to require basically a full rewrite. I think we should hold off on this feature until the React/Next rewrite (#189) is complete.

Ok cool

@KendallDoesCoding KendallDoesCoding added help wanted Help is required from contributors. on-hold Currently on-hold with the PR/Issue or waiting for help. labels Feb 7, 2022
@KendallDoesCoding
Copy link
Owner Author

If someone else can work on this in the current way it is, ig we'll proceed. Hope that's fine @TechStudent11

@TechStudent10
Copy link
Collaborator

If someone else can work on this in the current way it is, ig we'll proceed. Hope that's fine @TechStudent11

yeah sorry. I've been working on a mobile app, so I haven't been working on anything else, really.

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Feb 12, 2022 via email

@TechStudent10
Copy link
Collaborator

No, you said we should do this after we convert it to React or Next.JS so that's why I asked this.

Ohh okay.

I kinda knew you were using the mobile app.

No, as in I am coding a mobile app.

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Feb 12, 2022 via email

@TechStudent10
Copy link
Collaborator

Ok oh, what are you using? Android Studio?

I'm using React Native with the Expo CLI.

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Feb 13, 2022 via email

@KendallDoesCoding KendallDoesCoding added the javascript Javascript PR or a Javascript related issue with code. label Feb 20, 2022
@KendallDoesCoding KendallDoesCoding added 🟥 priority: critical 🟧 priority: high 🏁 status: ready for dev 🚧 status: blocked on-hold Currently on-hold with the PR/Issue or waiting for help. and removed 🟥 priority: critical on-hold Currently on-hold with the PR/Issue or waiting for help. 🚧 status: blocked labels Mar 7, 2022
@KendallDoesCoding KendallDoesCoding added this to the To Be Done by 2023 milestone May 23, 2022
@KendallDoesCoding
Copy link
Owner Author

I aim for this to be done by July 2022, but, as @TechStudent11 said, I'm sure not sure if #189 needs to be done before this for this to work.

@KendallDoesCoding
Copy link
Owner Author

@TechStudent11 Is this possible in a .mp3 version/offline version... I'm getting to work on that soon.

Example: http://music-in-browser.test.kendalldoescoding.gq/

@ArhyaSaha
Copy link
Contributor

Hi @KendallDoesCoding i think there should also be a pause button.

@KendallDoesCoding
Copy link
Owner Author

Hi @KendallDoesCoding i think there should also be a pause button.

Hi @ArhyaSaha , This would be better if it is part of #105 instead of on this issue, this issue is solely for the purpose of a button to loop the song.

@KendallDoesCoding KendallDoesCoding mentioned this issue Aug 24, 2022
Closed
@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Sep 21, 2022 •
edited
Loading

@CipherKill as you helped with the stop button, would you be able to help with the loop button as well?

@ReptilianPride
Copy link
Contributor

ReptilianPride commented Sep 22, 2022 •
edited
Loading

To recap, you need a loop button that would play the played/playing song from the beginning ? @KendallDoesCoding

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Sep 22, 2022 via email

@ReptilianPride
Copy link
Contributor

It's possible, but using "loop=1" on the URL isn't the way to go. I'll test out an idea I have and let you know here.

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Sep 22, 2022 via email

@ReptilianPride
Copy link
Contributor

Sure!

@ReptilianPride
Copy link
Contributor

Hey! Good news, got it to work. Making a PR now.

@ReptilianPride ReptilianPride mentioned this issue Sep 23, 2022
Merged
4 tasks
@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Sep 23, 2022 via email

KendallDoesCoding pushed a commit that referenced this issue Sep 24, 2022
@ReptilianPride
Loop feature (addressing issue #187) (#332)
84f3f1a 
* Added loop button and style (yet to add function)

* Loop feature complete

* Cleaned up some code
@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliraza944 aliraza944

@TechStudent10 TechStudent10

Labels
enhancement New feature or request help wanted Help is required from contributors. javascript Javascript PR or a Javascript related issue with code. on-hold Currently on-hold with the PR/Issue or waiting for help. 🔢 points: 8 🟧 priority: high 🏁 status: ready for dev
Projects
Mogul Christmas Updates on Priority
Status: Done
Milestone
To Be Done by 2023
Development

Successfully merging a pull request may close this issue.

Loop feature (addressing issue #187) ReptilianPride/mogul-christmas
5 participants
@ReptilianPride @aliraza944 @TechStudent10 @KendallDoesCoding @ArhyaSaha