Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the Lyrics/Individual Song Page and Mogul Christmas Playlist button to the top right/left corner #106

Closed
KendallDoesCoding opened this issue Jan 12, 2022 · 24 comments · Fixed by #336
Closed

Move the Lyrics/Individual Song Page and Mogul Christmas Playlist button to the top right/left corner #106

KendallDoesCoding opened this issue Jan 12, 2022 · 24 comments · Fixed by #336
Assignees
@Vedant-Manjrekar
Labels
css CSS PR or a CSS related issue with code. EddieHub:good-first-issue For the issue to show up on http://finder.eddiehub.org/ enhancement New feature or request good first issue Good for newcomers Hacktoberfest-Accepted help wanted Help is required from contributors. html HTML PR or a HTML related issue with code. on-hold Currently on-hold with the PR/Issue or waiting for help. 🔢 points: 5 🟩 priority: low 🏁 status: ready for dev UI/UX
Milestone
To Be Done by Jun...

Comments

@KendallDoesCoding
Copy link
Owner

Make a hamburger menu or a basic menu where the 2 buttons, Mogul Christmas Playlist and Lyrics/Individual Song Page are moved, the toggle button will have to be moved somewhere else though. Also, if the screen size is small the menu will be a icon and will show the buttons only if the user taps the small icon, like I got for my main website.
@KendallDoesCoding KendallDoesCoding added enhancement New feature or request help wanted Help is required from contributors. labels Jan 12, 2022
@KendallDoesCoding
Copy link
Owner Author

@aliraza944 Can you help with this, Ik how to do it but if you could help that would be very cool. Thanks

@KendallDoesCoding KendallDoesCoding added css CSS PR or a CSS related issue with code. good first issue Good for newcomers html HTML PR or a HTML related issue with code. labels Jan 17, 2022
@KendallDoesCoding
Copy link
Owner Author

@TechStudent11 Do you know how to do this? If yes, can you help me out with it?

@TechStudent10
Copy link
Collaborator

Hmmm tbh idk how.

@KendallDoesCoding
Copy link
Owner Author

Hmmm tbh idk how.

Ok

@KendallDoesCoding KendallDoesCoding added the on-hold Currently on-hold with the PR/Issue or waiting for help. label Feb 4, 2022
@KendallDoesCoding
Copy link
Owner Author

@Panquesito7 Do you know how to do this? If yes, can you make a PR? Or, is it not your style and you prefer the JS issues?

@KendallDoesCoding KendallDoesCoding mentioned this issue Feb 18, 2022
Closed
@KendallDoesCoding KendallDoesCoding added EddieHub:good-first-issue For the issue to show up on http://finder.eddiehub.org/ 🔢 points: 5 🏁 status: ready for dev 🚧 status: blocked on-hold Currently on-hold with the PR/Issue or waiting for help. and removed on-hold Currently on-hold with the PR/Issue or waiting for help. 🚧 status: blocked labels Mar 2, 2022
@KendallDoesCoding KendallDoesCoding added this to the To Be Done by June milestone Apr 13, 2022
@KendallDoesCoding
Copy link
Owner Author

@JeffBucherDev I believe your good at CSS, would you be able to get this done.

@KendallDoesCoding
Copy link
Owner Author

@JeffBucherDev I believe your good at CSS, would you be able to get this done.

@JeffBucherDev Please let me know.

@Vedant-Manjrekar
Copy link
Contributor

Hey @KendallDoesCoding is this issue resolved ?
The instructions above are little unclear, if you can screenshot and point out what kind of changes you need I'll be more than happy to help.

@KendallDoesCoding
Copy link
Owner Author

Hey @Vedant-Manjrekar , no it hasn't been resolved.

I basically want to list some of the buttons in the top left of the website, and if the user is on mobile, have a hamburger menu to list all the buttons within that, if possible.

This is just a idea that I thought long ago, but I'm not too sure about it now, because idk how exactly it will look.

Thanks,
KendallDoesCoding

@Vedant-Manjrekar
Copy link
Contributor

I think a navbar is what you are looking for, and i can do it, just assign me for it.
Also which buttons do you want on top left of the website?

@KendallDoesCoding
Copy link
Owner Author

I think a navbar is what you are looking for, and i can do it, just assign me for it. Also which buttons do you want on top left of the website?

Yup, I couldn't get the word for it.

Lyrics/Individual Song Page
You May Like

@Vedant-Manjrekar
Copy link
Contributor

@KendallDoesCoding How's this:
Screenshot 2022-10-03 at 3 34 17 PM
Screenshot 2022-10-03 at 3 34 29 PM
Screenshot 2022-10-03 at 3 34 56 PM
Screenshot 2022-10-03 at 3 35 07 PM

@KendallDoesCoding
Copy link
Owner Author

@KendallDoesCoding How's this: Screenshot 2022-10-03 at 3 34 17 PM Screenshot 2022-10-03 at 3 34 29 PM Screenshot 2022-10-03 at 3 34 56 PM Screenshot 2022-10-03 at 3 35 07 PM

Looks great, but I want the background colors of the buttons (like they are currently on the navbar as well) and if possible the same background color for the menu on mobile.

@Vedant-Manjrekar
Copy link
Contributor

Check this out:

Screenshot 2022-10-03 at 5 19 44 PM

Screenshot 2022-10-03 at 5 19 13 PM

PM.png…]()

I kept "you may also like" in menu white as it was not having any background color

@KendallDoesCoding
Copy link
Owner Author

Check this out:

Screenshot 2022-10-03 at 5 19 44 PM Screenshot 2022-10-03 at 5 19 13 PM

PM.png…]()
I kept "you may also like" in menu white as it was not having any background color

Looks better! Although still some things gotta be adjusted, but make a PR, I will adjust them and merge.

@KendallDoesCoding
Copy link
Owner Author

btw, I only want the menu for mobile screens, for laptop and big screens it can be as is, with the two buttons in the left.

@Vedant-Manjrekar
Copy link
Contributor

Yup I can take care of it, so is that it, should I make PR then?

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Oct 3, 2022 via email

@Vedant-Manjrekar
Copy link
Contributor

Vedant-Manjrekar commented Oct 3, 2022 •
edited
Loading

btw, I only want the menu for mobile screens, for laptop and big screens it can be as is, with the two buttons in the left.

But how will the desktop users access photo gallery and lugwig socials etc? If menu is not visible to them

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Oct 3, 2022 via email

@Vedant-Manjrekar Vedant-Manjrekar mentioned this issue Oct 3, 2022
Merged
7 tasks
@Vedant-Manjrekar
Copy link
Contributor

Vedant-Manjrekar commented Oct 3, 2022 •
edited
Loading

@KendallDoesCoding can you label this PR as "Hacktoberfest-Accepted"?

@KendallDoesCoding
Copy link
Owner Author

@KendallDoesCoding can you label this PR as "Hacktoberfest-Accepted"?

Done

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Oct 11, 2022 via email

@Vedant-Manjrekar
Copy link
Contributor

Yes, it will make my PR eligible for hacktober fest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vedant-Manjrekar Vedant-Manjrekar

Labels
css CSS PR or a CSS related issue with code. EddieHub:good-first-issue For the issue to show up on http://finder.eddiehub.org/ enhancement New feature or request good first issue Good for newcomers Hacktoberfest-Accepted help wanted Help is required from contributors. html HTML PR or a HTML related issue with code. on-hold Currently on-hold with the PR/Issue or waiting for help. 🔢 points: 5 🟩 priority: low 🏁 status: ready for dev UI/UX
Projects
None yet
Milestone
To Be Done by June 2022
Development

Successfully merging a pull request may close this issue.

Added Navbar to the Website. Vedant-Manjrekar/mogul-christmas
3 participants
@TechStudent10 @KendallDoesCoding @Vedant-Manjrekar