Merged
Conversation
emarc-m
reviewed
Jul 25, 2024
Collaborator
emarc-m
left a comment
emarc-m
left a comment
There was a problem hiding this comment.
Thank you Dylan. Just a clarification on the compatibility check removal.
|
|
||
| applyTargetOptions(context); | ||
|
|
||
| final boolean hasKitkat = Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT; |
Collaborator
There was a problem hiding this comment.
The compatibility check is no longer required even if min SDK 14 (ICS)? Can you please try the sample app with an emulator?
emarc-m
approved these changes
Aug 16, 2024
Collaborator
emarc-m
left a comment
emarc-m
left a comment
There was a problem hiding this comment.
Thank you Dylan. I will take care of publishing this to Maven and update you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes