Minimal v0.44 app, without deleting unupgraded packages #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build time. This is shown in the tendermint /status endpoint
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
nddeluca
reviewed
Oct 22, 2021
Closed
nddeluca
reviewed
Oct 26, 2021
nddeluca
reviewed
Oct 26, 2021
nddeluca
approved these changes
Oct 26, 2021
DracoLi
reviewed
Oct 26, 2021
app/ante/ante_test.go
Outdated
| for i := range addresses { | ||
| coinsList[i] = coins | ||
| // NewFundedGenStateWithSameCoins creates a (auth and bank) genesis state populated with accounts from the given addresses and balance. | ||
| func NewFundedGenStateWithSameCoins(cdc codec.JSONCodec, balance sdk.Coins, addresses []sdk.AccAddress) app.GenesisState { |
There was a problem hiding this comment.
should we move this to test_common? NewAuthGenState from test_common should do the same thing but is currently not returning the gen state for the bank module so its not giving the accounts any coins
There was a problem hiding this comment.
yeah that makes sense, moved in 18a2266
DracoLi
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the app and upgrades it to sdk v0.44.2.
The app can be run with
make installthenmake start.Previously I'd planned to delete all packages, then add them back in as they were upgraded. This would avoid having uncompilable code hanging out in the repo causing problems with go tooling (go test, go mod tidy, etc).
However, this means that PRs will have no diff against the old code, making reviews more difficult and removing PRs as a source of documentation.
An alternative is to not delete modules, but to "ignore" them by adding an empty go.mod file. This makes various go tools ignore their contents -
go mod tidy,go test ./...all work.A downside is vscode/gopls does not ignore the contents, and on my machine maxes out cpu. Best way I have of fixing this is locally renaming folders/files with a "_" prefix, to make go (and gopls) completely ignore them.
If we do want to delete all modules, we can use #1028
Main Changes
kavabinary replaceskvdandkvcli