Skip to content

Commit

Permalink
nfsd4: make del_recall_lru per-network-namespace
Browse files Browse the repository at this point in the history
If nothing else this simplifies the nfs4_state_shutdown_net logic a tad.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Apr 4, 2013
1 parent 68a3396 commit e8c69d1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
1 change: 1 addition & 0 deletions fs/nfsd/netns.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ struct nfsd_net {
*/
struct list_head client_lru;
struct list_head close_lru;
struct list_head del_recall_lru;

struct delayed_work laundromat_work;

Expand Down
15 changes: 7 additions & 8 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,6 @@ opaque_hashval(const void *ptr, int nbytes)
return x;
}

static struct list_head del_recall_lru;

static void nfsd4_free_file(struct nfs4_file *f)
{
kmem_cache_free(file_slab, f);
Expand Down Expand Up @@ -2583,14 +2581,17 @@ nfs4_share_conflict(struct svc_fh *current_fh, unsigned int deny_type)

static void nfsd_break_one_deleg(struct nfs4_delegation *dp)
{
struct nfs4_client *clp = dp->dl_stid.sc_client;
struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id);

/* We're assuming the state code never drops its reference
* without first removing the lease. Since we're in this lease
* callback (and since the lease code is serialized by the kernel
* lock) we know the server hasn't removed the lease yet, we know
* it's safe to take a reference: */
atomic_inc(&dp->dl_count);

list_add_tail(&dp->dl_recall_lru, &del_recall_lru);
list_add_tail(&dp->dl_recall_lru, &nn->del_recall_lru);

/* only place dl_time is set. protected by lock_flocks*/
dp->dl_time = get_seconds();
Expand Down Expand Up @@ -3254,7 +3255,7 @@ nfs4_laundromat(struct nfsd_net *nn)
expire_client(clp);
}
spin_lock(&recall_lock);
list_for_each_safe(pos, next, &del_recall_lru) {
list_for_each_safe(pos, next, &nn->del_recall_lru) {
dp = list_entry (pos, struct nfs4_delegation, dl_recall_lru);
if (net_generic(dp->dl_stid.sc_client->net, nfsd_net_id) != nn)
continue;
Expand Down Expand Up @@ -4810,7 +4811,6 @@ struct nfs4_client *nfsd_find_client(struct sockaddr_storage *addr, size_t addr_
void
nfs4_state_init(void)
{
INIT_LIST_HEAD(&del_recall_lru);
}

/*
Expand Down Expand Up @@ -4874,6 +4874,7 @@ static int nfs4_state_create_net(struct net *net)
nn->unconf_name_tree = RB_ROOT;
INIT_LIST_HEAD(&nn->client_lru);
INIT_LIST_HEAD(&nn->close_lru);
INIT_LIST_HEAD(&nn->del_recall_lru);
spin_lock_init(&nn->client_lock);

INIT_DELAYED_WORK(&nn->laundromat_work, laundromat_main);
Expand Down Expand Up @@ -4986,10 +4987,8 @@ nfs4_state_shutdown_net(struct net *net)

INIT_LIST_HEAD(&reaplist);
spin_lock(&recall_lock);
list_for_each_safe(pos, next, &del_recall_lru) {
list_for_each_safe(pos, next, &nn->del_recall_lru) {
dp = list_entry (pos, struct nfs4_delegation, dl_recall_lru);
if (dp->dl_stid.sc_client->net != net)
continue;
list_move(&dp->dl_recall_lru, &reaplist);
}
spin_unlock(&recall_lock);
Expand Down

0 comments on commit e8c69d1

Please sign in to comment.