Skip to content

Commit

Permalink
checkpatch: switch -- report trailing statements on case and default
Browse files Browse the repository at this point in the history
Report trailing statements on case and default lines.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
awhitcroft authored and torvalds committed Jul 24, 2008
1 parent f4c014c commit e2a763c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions scripts/checkpatch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,10 @@ sub process {
ERROR("switch and case should be at the same indent\n$hereline$err");
}
}
if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
$line !~ /\G(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$/g) {
ERROR("trailing statements should be on next line\n" . $herecurr);
}

# if/while/etc brace do not go on next line, unless defining a do while loop,
# or if that brace on the next line is for something else
Expand Down

0 comments on commit e2a763c

Please sign in to comment.