Skip to content

Commit

Permalink
mpls: Move reserved label definitions
Browse files Browse the repository at this point in the history
Move to include/uapi/linux/mpls.h to be externally visibile.

Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
tomratbert authored and davem330 committed May 5, 2015
1 parent bc321ed commit c967a08
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 19 deletions.
10 changes: 10 additions & 0 deletions include/uapi/linux/mpls.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,14 @@ struct mpls_label {
#define MPLS_LS_TTL_MASK 0x000000FF
#define MPLS_LS_TTL_SHIFT 0

/* Reserved labels */
#define MPLS_LABEL_IPV4_EXPLICIT_NULL 0 /* RFC3032 */
#define MPLS_LABEL_ROUTER_ALERT 1 /* RFC3032 */
#define MPLS_LABEL_IPV6_EXPLICIT_NULL 2 /* RFC3032 */
#define MPLS_LABEL_IMPLICIT_NULL 3 /* RFC3032 */
#define MPLS_LABEL_ENTROPY_INDICATOR 7 /* RFC6790 */
#define MPLS_LABEL_GAL 13 /* RFC5586 */
#define MPLS_LABEL_OAM_ALERT 14 /* RFC3429 */
#define MPLS_LABEL_EXTENSION 15 /* RFC7274 */

#endif /* _UAPI_MPLS_H */
18 changes: 9 additions & 9 deletions net/mpls/af_mpls.c
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ int nla_get_labels(const struct nlattr *nla,
return -EINVAL;

switch (dec.label) {
case LABEL_IMPLICIT_NULL:
case MPLS_LABEL_IMPLICIT_NULL:
/* RFC3032: This is a label that an LSR may
* assign and distribute, but which never
* actually appears in the encapsulation.
Expand Down Expand Up @@ -935,7 +935,7 @@ static int resize_platform_label_table(struct net *net, size_t limit)
}

/* In case the predefined labels need to be populated */
if (limit > LABEL_IPV4_EXPLICIT_NULL) {
if (limit > MPLS_LABEL_IPV4_EXPLICIT_NULL) {
struct net_device *lo = net->loopback_dev;
rt0 = mpls_rt_alloc(lo->addr_len);
if (!rt0)
Expand All @@ -945,7 +945,7 @@ static int resize_platform_label_table(struct net *net, size_t limit)
rt0->rt_via_table = NEIGH_LINK_TABLE;
memcpy(rt0->rt_via, lo->dev_addr, lo->addr_len);
}
if (limit > LABEL_IPV6_EXPLICIT_NULL) {
if (limit > MPLS_LABEL_IPV6_EXPLICIT_NULL) {
struct net_device *lo = net->loopback_dev;
rt2 = mpls_rt_alloc(lo->addr_len);
if (!rt2)
Expand Down Expand Up @@ -973,15 +973,15 @@ static int resize_platform_label_table(struct net *net, size_t limit)
memcpy(labels, old, cp_size);

/* If needed set the predefined labels */
if ((old_limit <= LABEL_IPV6_EXPLICIT_NULL) &&
(limit > LABEL_IPV6_EXPLICIT_NULL)) {
RCU_INIT_POINTER(labels[LABEL_IPV6_EXPLICIT_NULL], rt2);
if ((old_limit <= MPLS_LABEL_IPV6_EXPLICIT_NULL) &&
(limit > MPLS_LABEL_IPV6_EXPLICIT_NULL)) {
RCU_INIT_POINTER(labels[MPLS_LABEL_IPV6_EXPLICIT_NULL], rt2);
rt2 = NULL;
}

if ((old_limit <= LABEL_IPV4_EXPLICIT_NULL) &&
(limit > LABEL_IPV4_EXPLICIT_NULL)) {
RCU_INIT_POINTER(labels[LABEL_IPV4_EXPLICIT_NULL], rt0);
if ((old_limit <= MPLS_LABEL_IPV4_EXPLICIT_NULL) &&
(limit > MPLS_LABEL_IPV4_EXPLICIT_NULL)) {
RCU_INIT_POINTER(labels[MPLS_LABEL_IPV4_EXPLICIT_NULL], rt0);
rt0 = NULL;
}

Expand Down
10 changes: 0 additions & 10 deletions net/mpls/internal.h
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
#ifndef MPLS_INTERNAL_H
#define MPLS_INTERNAL_H

#define LABEL_IPV4_EXPLICIT_NULL 0 /* RFC3032 */
#define LABEL_ROUTER_ALERT_LABEL 1 /* RFC3032 */
#define LABEL_IPV6_EXPLICIT_NULL 2 /* RFC3032 */
#define LABEL_IMPLICIT_NULL 3 /* RFC3032 */
#define LABEL_ENTROPY_INDICATOR 7 /* RFC6790 */
#define LABEL_GAL 13 /* RFC5586 */
#define LABEL_OAM_ALERT 14 /* RFC3429 */
#define LABEL_EXTENSION 15 /* RFC7274 */


struct mpls_shim_hdr {
__be32 label_stack_entry;
};
Expand Down

0 comments on commit c967a08

Please sign in to comment.