Update timelimit computation to new standard (also applying the change to legacy packages) #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll with integers)
…ted for lower bound)
pehrsoderman
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the time limit computation to the new standard.
I decided to apply the same change to the legacy format (where time limit computation is completely unspecified), as we have issue #220 pointing out problem with the current legacy time limit computation.
Problemtools (but not Kattis!) now also supports fractional time limits. In the legacy format, we will always compute time limits in whole seconds, as we default
time_resolutionto 1 (and there's no way to set the resolution in legacy), but if you really want to, you could force it using-t 1.5. Problemtools will warn about time limits which are not in whole seconds.Supporting fractional time limits changes how we deal with safety margins around the time limit. Previously, we rounded everything to integers. Now, if the time limit is 1 second, and we want a factor 1.5 safety margin, we're OK with a TLE solution running in 1.51 seconds (earlier, we would have required 2).
Also fixes a bug in how we dealt with time limits for interactive problems.
Fixes #220
Fixes #302