Test coverage of default_validator
#364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkreitz
force-pushed
the
default_validator_fixes
branch
from
8c00038 to
8f7188a
Compare
Contributor
Author
|
D'oh, I named the new test in a way such that pytest autodiscovers it, but doesn't quite run it correctly. Actually, having it run from pytest is sort of nice. I'll think a bit more about how I want to structure this. |
Contributor
Author
|
I rewrote for pytest and moved everything to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm planning to work a bit on
default_validatorin #346, I first wanted to add some test coverage. As the test coverage ended up being a bit large on its own, I'm doing a separate PR for it here before touching the validator code.