Skip to content

Sanity check the parsed author names #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkreitz merged 1 commit into from
Sep 10, 2025
Merged

Sanity check the parsed author names #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions problemtools/verifyproblem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,13 @@ def check(self, context: Context) -> bool:
if not self._metadata.rights_owner and not self._metadata.source and not self._metadata.credits.authors:
self.error('No author, source or rights_owner provided')

# Sanity check that the author name is parsed reasonably
disallowed_in_name = [',', '&']
for author in self._metadata.credits.authors:
for disallowed_character in disallowed_in_name:
if disallowed_character in author.name:
self.warning(f'Author name parsed to "{author.name}", which contains character "{disallowed_character}".')

# Check license
if self._metadata.license == metadata.License.UNKNOWN:
self.warning("License is 'unknown'")
Expand Down