Skip to content

Conversation

@Matistjati
Copy link
Contributor

@Matistjati Matistjati commented Jun 16, 2025

Improve error message from
WARNING judge answer file got JE [output validator validator (C++) crashed, status 134]
to
WARNING judge answer file got JE [output validator validator (C++) crashed, status 134] on testcase data/secret/group1/1.ans

Second is much more helpful. Code fragility:

  • will throw an exception if there is no data in the path to the answer file. Should be impossible, as it won't be considered for being a testcase. Maybe symlinks can be weird? But iirc, we disallow symlinks going out of data.
  • Might give weird results if you have a subfolder in the test data named "data". At that point, blame yourself

Also, why doesn't python have a rindex function??? This is more ugly than it should be..

@Matistjati Matistjati force-pushed the better-judge-ans-je-message branch from 52ea83d to ac6c7f9 Compare June 16, 2025 00:20
@Matistjati Matistjati force-pushed the better-judge-ans-je-message branch from ac6c7f9 to d01efc0 Compare June 16, 2025 00:22
Copy link
Contributor

@gkreitz gkreitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to indicate the test case here. Long-term, we should be a bit smarter about this particular warning (but that's for a later day - I jotted down thoughts in #344).

Ignoring the more long-term idea I jotted down there, this looks good, but just use the existing function in the f-string when printing instead of the computation you added to get a relative path. :)

@gkreitz gkreitz merged commit 94d37f3 into Kattis:master Jun 16, 2025
5 checks passed
@Matistjati Matistjati deleted the better-judge-ans-je-message branch August 20, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants