Update problemtools packaging #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now package our debian package in a virtualenv, together with our dependencies, to allow us to just use normal pip dependencies instead of waiting for Ubuntu/Debian to package python dependencies for us. This means we now also list our requirements in requirements.txt. This change also bumped debian compat level to the most recent stable version, getting rid of deprecation warnings.
gkreitz
force-pushed
the
297_modernize_build
branch
4 times, most recently
from
5b946a5 to
dc24947
Compare
pehrsoderman
approved these changes
Apr 24, 2025
I could not come up with a good way to reliably make an editable install to work in setuptools in a way that kept our support tooling available. This reverts my earlier change of the README where I intended us to move to using an editable install for development work, and instead just updates our wrapper scripts to make use of a venv to pull in the correct dependencies.
This should make things a bit quicker (we can start with python tests without waiting for a ton of apt dependencies) and cheaper (we don't build deb twice). It also seems like *something* confuses dh_virtualenv, I'm starting to suspect actions/setup-python.
gkreitz
force-pushed
the
297_modernize_build
branch
from
dc24947 to
d99b67e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we package problemtools, to allow us to add pip dependencies without waiting for Ubuntu to package them.
Key changes:
dh_virtualenv(we now install to/opt/venvs/kattis-problemtools/and add symlinks from/usr/binfor our tools)pyproject.toml. We still need to keepsetup.pyto fetch and build our support tools.setuptools-scm(this yields a string which is very similar to our old versioning)problemtools.__version__. That PEP failed and was replaced byimportlib.metadata.versionFixes #297