-
Notifications
You must be signed in to change notification settings - Fork 78
Markdown support #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown support #274
Conversation
gkreitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took another pass over it, as requested. This is getting close to ready for merging. The main problem I see are a couple of places where we need to escape latex characters (the rendering path of markdown -> latex -> pdf that pandoc does is funky...).
gkreitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, code just had two small things. Tests failing due to UUID should be fixed by #307 merging (and then rebasing on that).
For example problems, I'm ok with merging this as-is, but if so we should do a follow-up soon where we convert the problems to 2023-07.
| @@ -0,0 +1,20 @@ | |||
| Jag tänker på ett hemligt tal mellan $1$ and $100$, kan du gissa vilket? | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess is a legacy problem, which does/should not support markdown. I'd like for our examples to follow the standard.
One way to fix that would be to convert guess and/or oddecho (where you also added a markdown statement) to 2023-07-draft.
supported for both pdf and html:
$a+b$and$$a+b$$A PR of the spec can be found here Kattis/problem-package-format#386.
todo in follow-up pr:
not planned to be added in this PR (maybe ever):