Add -j flag for multi-threaded validation #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagl
reviewed
Jun 6, 2024
Contributor
Tagl
left a comment
Tagl
left a comment
There was a problem hiding this comment.
Good suggestion! Why the letter j? Just because t is in use?
Member
Author
-j is the customary flag for threading. Also used by e.g. |
pehrsoderman
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only parallelizes test case execution and submission compilation at the moment; input validation could be added with a bit of additional work, but it felt less important to me since it takes almost no time with validators written in C++ as we usually have it.
mypy is happy with the refactoring and I've done some lightweight testing, but it's possible that there's some breakage along less happy paths, though probably restricted to -j.