Skip to content

Fix crash in verifyproblem when in or ans files are not utf-8 #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pehrsoderman merged 1 commit into from
Jan 25, 2024
Merged

Fix crash in verifyproblem when in or ans files are not utf-8 #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions problemtools/verifyproblem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,13 @@ def __init__(self, problem: Problem, base: str, testcasegroup: TestCaseGroup):
problem.testcase_by_infile[self.infile] = self

def check_newlines(self, filename: str) -> None:
with open(filename, 'r') as f:
data = f.read()
with open(filename, 'rb') as f:
rawdata = f.read()
try:
data = rawdata.decode('utf-8', 'strict')
except UnicodeDecodeError:
self.warning(f'The file {filename} could not be decoded as utf-8')
return
if data.find('\r') != -1:
self.warning(f'The file {filename} contains non-standard line breaks.')
if len(data) > 0 and data[-1] != '\n':
Expand Down