Backport filename fix from #494 to legacy #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemela
approved these changes
Nov 28, 2025
This was referenced Nov 28, 2025
Tagl
approved these changes
Dec 6, 2025
Matistjati
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expressions for allowed file and directory names turned out to be overly restrictive when actually implemented. This was addressed for 2025-09 in #494 . This PR backports the same changes to legacy, as the same problems with leading dots and underscores exist there, and it is still the current version of the standard.
I intentionally also copied the language from 2025-09 making the regexp apply to both file and directory names. Earlier, only file names had a regexp in legacy.