Merged
Conversation
ehelms
approved these changes
Jan 5, 2024
ekohl
reviewed
Jan 5, 2024
Comment on lines
25
to
26
| - name: Run Rubocop | ||
| run: bundle exec rubocop |
Member
There was a problem hiding this comment.
Do we want to run rubocop in a matrix as well? Thoughts on just using https://github.com/theforeman/actions#rubocop & https://github.com/theforeman/actions#gem-test instead?
Member
Author
There was a problem hiding this comment.
I didn't want to disrupt the rest of the action just yet.
Matrixing Rubocop doesn't hurt. Long term we should move to shared actions, but IMHO don't need today.
ianballou
approved these changes
Jan 5, 2024
Member
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
Looking good to me. If not done now, should we make a redmine for the rubocop matrixing?
Member
Author
|
Nah, it's fine. There is some general discussion about how we could/should test proxy plugins in theforeman/actions#27 Depending on the outcome, I'd then see to open PRs or Redmines ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.