Fixes #37858 - Send events on angular translation load #11158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
reviewed
Sep 23, 2024
MariaAga
force-pushed
the
angular-events
branch
from
c143e12
to
c4694cb
Compare
|
Thanks! thought it would be ok since it did fire the events |
MariaAga
force-pushed
the
angular-events
branch
from
c4694cb
to
61fad1f
Compare
Yeah I think browsers handle it just fine, it's probably just our tests or grunt or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Sending events after loading i18n and gettext in angular
Considerations taken when implementing this change?
Could not know when they are loaded otherwise.
Tried using MutationObserver to see when the script to load them was called, but that happens just before they are loaded.
The deface for branding needs to happen (from
engines/bastion/app/views/bastion/layouts/assets.html.erb):<%= javascript_include_tag('bastion/bastion', {type: 'module'})%>translate(..., I think its in:<%= javascript_include_tag('bastion_katello/bastion_katello', {type: 'module'}) %>What are the testing steps for this pull request?
I dont see how it could break anything