Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36628 - update audit is not created after updating CV name #10672

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fixes #36628 - update audit is not created after updating CV name #10672

merged 1 commit into from
Aug 2, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Aug 1, 2023

What are the changes introduced in this pull request?

Adds audit back to name,label,description fields. (label can't be changed but no benefit of excluding it specifically.)

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Create a CV
  2. Update name/description of CV
  3. Go to Monitor > Audits
  4. Check if an audit record is created for the updates on name/description.

@theforeman-bot
Copy link

Issues: #36628

chris1984
chris1984 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, code looks fine and it works well

Screenshot 2023-08-02 at 12-05-17 Audits

@chris1984 chris1984 self-assigned this Aug 2, 2023
@sjha4 sjha4 merged commit a14bb3f into Katello:master Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees

@chris1984 chris1984

Labels
Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjha4 @theforeman-bot @chris1984