Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36623 - Add buttons and other UX improvements to change content source #10670

Conversation

jeremylenz
Copy link
Member

@jeremylenz jeremylenz commented Jul 31, 2023

What are the changes introduced in this pull request?

Add buttons to the Change Content Source screen so it's less confusing.

image

When you click either of the buttons, the content source is updated on the Foreman / Satellite server.

In the case of 'Run job invocation', you are then redirected to the job wizard.
In the case of 'Update hosts manually', the following is presented:

image

Other changes:

  • Add a description blurb explaining why you might want to change a content source
  • Change 'Environment' to 'Lifecycle environment'. I feel like 'Environment' can mean too many things, and want to start getting away from using it to describe lifecycle environments.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

You should be able to test this without actually setting up multiple content sources.

@theforeman-bot
Copy link

Issues: #36623

@jeremylenz jeremylenz changed the title 36623 add buttons to change content source Fixes #36623 - Add buttons and other UX improvements to change content source Jul 31, 2023
@jeremylenz
Copy link
Member Author

will rebase once #10667 is merged

@jeremylenz jeremylenz force-pushed the 36623-add-buttons-to-change-content-source branch from 5225fad to ec0fbe2 Compare August 1, 2023 19:03
@jeremylenz
Copy link
Member Author

@chris1984 rebased

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, works great and nice UI change. Code looks fine, thanks for answering my question.

Screenshot 2023-08-03 at 12-20-08 Change host content source
Screenshot 2023-08-03 at 12-21-51 Change host content source
Screenshot 2023-08-03 at 12-22-42 Change host content source
Screenshot 2023-08-03 at 12-41-12 Run job

@jeremylenz jeremylenz merged commit ad9bfef into Katello:master Aug 3, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants