Skip to content

Commit

Permalink
Update global-workflow and subcomponents to Hera/Rocky 8 partition (N…
Browse files Browse the repository at this point in the history
…OAA-EMC#2421)

This PR addresses issue NOAA-EMC#2329. The following is accomplished:

- All submodule RDHPCS Hera stacks are updated to be compatible with the
Rocky-8 distro spack-stack;
- The global-workflow version files `versions/build.hera.ver` and
`versions/run.hera.ver` are updated for Rocky-8;
- All submodule hashes have been updated to be compliant with the
Rocky-8 distro spack-stack (see the reference PRs below);
- Update to `parm/config/config.base` is made for not yet compliant
packages;
- Relevant updates are made to `modulefiles/module_base.hera.lua` and
`modulefiles/module_gwsetup.lua`.

  Resolves NOAA-EMC#2329
  Refs: [NOAA-EMC#958](NOAA-EMC/GDASApp#958)
           [NOAA-EMC#49](NOAA-EMC/gfs-utils#49)
           [NOAA-EMC#124](NOAA-EMC/GSI-Monitor#124)
           [NOAA-EMC#31](NOAA-EMC/GSI-utils#31)
[NOAA-EMC#2167](ufs-community/ufs-weather-model#2167)
[NOAA-EMC#2143](ufs-community/ufs-weather-model#2143)
           [NOAA-EMC#913](ufs-community/UFS_UTILS#913)

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
  • Loading branch information
3 people authored Mar 28, 2024
1 parent 4730215 commit d6be3b5
Show file tree
Hide file tree
Showing 20 changed files with 31 additions and 19 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@
[submodule "sorc/gsi_monitor.fd"]
path = sorc/gsi_monitor.fd
url = https://github.com/NOAA-EMC/GSI-Monitor.git
[submodule "sorc/upp.fd"]
path = sorc/upp.fd
url = https://github.com/NOAA-EMC/UPP.git
3 changes: 3 additions & 0 deletions ci/cases/pr/C48_S2SWA_gefs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ arguments:
idate: 2021032312
edate: 2021032312
yaml: {{ HOMEgfs }}/ci/cases/yamls/gefs_ci_defaults.yaml

skip_ci_on_hosts:
- hera
1 change: 1 addition & 0 deletions ci/cases/pr/C48mx500_3DVarAOWCDA.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ arguments:

skip_ci_on_hosts:
- orion
- hera
- hercules
2 changes: 1 addition & 1 deletion modulefiles/module_base.hera.lua
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ setenv("WGRIB2","wgrib2")
setenv("UTILROOT",(os.getenv("prod_util_ROOT") or "None"))

--prepend_path("MODULEPATH", pathJoin("/scratch1/NCEPDEV/global/glopara/git/prepobs/v" .. (os.getenv("prepobs_run_ver") or "None"), "modulefiles"))
prepend_path("MODULEPATH", pathJoin("/scratch1/NCEPDEV/global/glopara/git/prepobs/feature-GFSv17_com_reorg_log_update/modulefiles"))
prepend_path("MODULEPATH", pathJoin("/scratch1/NCEPDEV/global/glopara/git/prepobs/dev-gfsv17/modulefiles"))
load(pathJoin("prepobs", (os.getenv("prepobs_run_ver") or "None")))

prepend_path("MODULEPATH", pathJoin("/scratch1/NCEPDEV/global/glopara/git/Fit2Obs/v" .. (os.getenv("fit2obs_ver") or "None"), "modulefiles"))
Expand Down
2 changes: 1 addition & 1 deletion modulefiles/module_gwci.hera.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ help([[
Load environment to run GFS workflow setup scripts on Hera
]])

prepend_path("MODULEPATH", "/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/gsi-addon-dev/install/modulefiles/Core")
prepend_path("MODULEPATH", "/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/gsi-addon-dev-rocky8/install/modulefiles/Core")

load(pathJoin("stack-intel", os.getenv("2021.5.0")))
load(pathJoin("stack-intel-oneapi-mpi", os.getenv("2021.5.1")))
Expand Down
2 changes: 1 addition & 1 deletion modulefiles/module_gwsetup.hera.lua
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Load environment to run GFS workflow setup scripts on Hera

load(pathJoin("rocoto"))

prepend_path("MODULEPATH", "/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/gsi-addon-dev/install/modulefiles/Core")
prepend_path("MODULEPATH", "/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/gsi-addon-dev-rocky8/install/modulefiles/Core")

local stack_intel_ver=os.getenv("stack_intel_ver") or "2021.5.0"
local python_ver=os.getenv("python_ver") or "3.11.6"
Expand Down
5 changes: 4 additions & 1 deletion parm/config/gfs/config.base
Original file line number Diff line number Diff line change
Expand Up @@ -384,11 +384,14 @@ export FITSARC="YES"
export FHMAX_FITS=132
[[ "${FHMAX_FITS}" -gt "${FHMAX_GFS}" ]] && export FHMAX_FITS=${FHMAX_GFS}

# The monitor jobs are not yet supported for JEDIATMVAR
# The monitor jobs are not yet supported for JEDIATMVAR.
if [[ ${DO_JEDIATMVAR} = "YES" ]]; then
export DO_VERFOZN="NO" # Ozone data assimilation monitoring
export DO_VERFRAD="NO" # Radiance data assimilation monitoring
export DO_VMINMON="NO" # GSI minimization monitoring
# The minimization monitor is not yet supported on RDHPCS Hera for Rocky-8
elif [[ ${machine} = "HERA" ]]; then
export DO_VMINMON="NO" # GSI minimization monitoring
fi

echo "END: config.base"
2 changes: 1 addition & 1 deletion sorc/build_upp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ if [[ ! -d "../exec" ]]; then
mkdir -p ../exec
fi

cd ufs_model.fd/FV3/upp/tests
cd upp.fd/tests
# shellcheck disable=SC2086
BUILD_JOBS=${BUILD_JOBS:-8} ./compile_upp.sh ${_opts}
2 changes: 1 addition & 1 deletion sorc/gdas.cd
2 changes: 1 addition & 1 deletion sorc/gfs_utils.fd
Submodule gfs_utils.fd updated 50 files
+76 −0 .github/ISSUE_TEMPLATE/bug_report.yml
+1 −0 .github/ISSUE_TEMPLATE/config.yml
+55 −0 .github/ISSUE_TEMPLATE/feature_request.yml
+52 −0 .github/pull_request_template.md
+37 −0 .github/workflows/linters.yaml
+24 −0 .github/workflows/pynorms.yaml
+4 −6 CMakeLists.txt
+21 −41 cmake/Findgempak.cmake
+7 −6 cmake/Findgfortran.cmake
+0 −2 modulefiles/gfsutils_common.lua
+1 −1 modulefiles/gfsutils_hera.intel.lua
+0 −2 modulefiles/gfsutils_wcoss2.intel.lua
+26 −0 modulefiles/rdbfmsua_hera.intel.lua
+25 −0 modulefiles/rdbfmsua_orion.intel.lua
+25 −0 modulefiles/rdbfmsua_wcoss2.intel.lua
+15 −1 src/CMakeLists.txt
+12 −0 src/ensadd.fd/CMakeLists.txt
+187 −0 src/ensadd.fd/ENSADD.f90
+82 −0 src/ensadd.fd/printinfr.f90
+13 −0 src/ensppf.fd/CMakeLists.txt
+350 −0 src/ensppf.fd/ENSPPF.f90
+57 −0 src/ensppf.fd/init_parm.f90
+96 −0 src/ensppf.fd/printinfr.f90
+17 −0 src/ensstat.fd/CMakeLists.txt
+365 −0 src/ensstat.fd/EPDF.f
+51 −0 src/ensstat.fd/SORTMM.f
+391 −0 src/ensstat.fd/ensstat.f90
+98 −0 src/ensstat.fd/gtbits.f90
+57 −0 src/ensstat.fd/init_parm.f90
+45 −0 src/ensstat.fd/isrchne.f90
+82 −0 src/ensstat.fd/printinfr.f90
+8 −8 src/ocnicepost.fd/init_mod.F90
+4 −2 src/ocnicepost.fd/ocnicepost.F90
+7 −3 src/ocnicepost.fd/utils_mod.F90
+1 −2 src/rdbfmsua.fd/CMakeLists.txt
+8 −73 src/rdbfmsua.fd/makefile
+0 −88 src/rdbfmsua.fd/makefile.hera
+9 −0 src/rdbfmsua.fd/makefile.hera.intel
+9 −0 src/rdbfmsua.fd/makefile.orion.intel
+6 −0 src/rdbfmsua.fd/makefile.wcoss2.intel
+0 −0 src/rdbfmsua.fd/to_be_deleted/MAPFILE
+0 −0 src/rdbfmsua.fd/to_be_deleted/README
+0 −0 src/rdbfmsua.fd/to_be_deleted/README.new
+0 −0 src/rdbfmsua.fd/to_be_deleted/makefile.wcoss_cray
+0 −0 src/rdbfmsua.fd/to_be_deleted/makefile.wcoss_dell_p3
+0 −0 src/rdbfmsua.fd/to_be_deleted/rdbfmsua.f_org
+12 −0 src/wave_stat.fd/CMakeLists.txt
+263 −0 src/wave_stat.fd/grbit2.f90
+348 −0 src/wave_stat.fd/wave_stat.f90
+32 −11 ush/build.sh
2 changes: 1 addition & 1 deletion sorc/gsi_enkf.fd
Submodule gsi_enkf.fd updated 78 files
+2 −0 CMakeLists.txt
+1 −0 INSTALL.md
+1 −1 fix
+1 −1 modulefiles/gsi_gaea.intel.lua
+1 −1 modulefiles/gsi_hera.gnu.lua
+2 −2 modulefiles/gsi_hera.intel.lua
+1 −1 modulefiles/gsi_hercules.intel.lua
+1 −1 modulefiles/gsi_jet.intel.lua
+1 −1 modulefiles/gsi_orion.intel.lua
+1 −1 modulefiles/gsi_s4.intel.lua
+1 −1 modulefiles/gsi_wcoss2.intel.lua
+28 −27 regression/global_4denvar.sh
+8 −11 regression/global_enkf.sh
+2 −0 regression/regression_driver.sh
+24 −24 regression/regression_param.sh
+1 −1 regression/regression_var.sh
+5 −0 src/CMakeLists.txt
+10 −6 src/enkf/controlvec.f90
+2 −0 src/enkf/gridinfo_fv3reg.f90
+2 −0 src/enkf/gridinfo_nmmb.f90
+2 −0 src/enkf/gridinfo_wrf.f90
+442 −11 src/enkf/gridio_gfs.f90
+15 −0 src/gsi/CMakeLists.txt
+1 −1 src/gsi/calc_fov_crosstrk.f90
+1 −1 src/gsi/clw_mod.f90
+1 −1 src/gsi/cmake/gsiapp_compiler_flags_Intel_Fortran.cmake
+1 −1 src/gsi/cplr_get_fv3_regional_ensperts.f90
+47 −91 src/gsi/deter_sfc_mod.f90
+334 −209 src/gsi/gsi_rfv3io_mod.f90
+16 −2 src/gsi/gsimod.F90
+376 −139 src/gsi/hybrid_ensemble_isotropic.F90
+5 −0 src/gsi/hybrid_ensemble_parameters.f90
+1 −1 src/gsi/intjcmod.f90
+3 −5 src/gsi/mod_fv3_lola.f90
+1 −5 src/gsi/radiance_mod.f90
+1 −1 src/gsi/radinfo.f90
+8 −4 src/gsi/read_cris.f90
+2 −2 src/gsi/read_fl_hdob.f90
+3 −3 src/gsi/read_gmi.f90
+6 −6 src/gsi/read_nsstbufr.f90
+42 −19 src/gsi/read_ozone.f90
+13 −11 src/gsi/read_radar.f90
+7 −6 src/gsi/setuprad.f90
+9 −20 src/gsi/ssmis_spatial_average_mod.f90
+2 −2 src/gsi/stpcalc.f90
+98 −0 src/mgbf/CMakeLists.txt
+19 −0 src/mgbf/cmake/PackageConfig.cmake.in
+1,119 −0 src/mgbf/jp_pbfil.f90
+1,173 −0 src/mgbf/jp_pbfil2.f90
+2,620 −0 src/mgbf/jp_pbfil3.f90
+111 −0 src/mgbf/jp_pietc.f90
+113 −0 src/mgbf/jp_pietc_s.f90
+34 −0 src/mgbf/jp_pkind.f90
+25 −0 src/mgbf/jp_pkind2.f90
+1,096 −0 src/mgbf/jp_pmat.f90
+2,086 −0 src/mgbf/jp_pmat4.f90
+118 −0 src/mgbf/kinds.f90
+8,016 −0 src/mgbf/mg_bocos.f90
+644 −0 src/mgbf/mg_domain.f90
+796 −0 src/mgbf/mg_domain_loc.f90
+158 −0 src/mgbf/mg_entrymod.f90
+1,629 −0 src/mgbf/mg_filtering.f90
+1,756 −0 src/mgbf/mg_generations.f90
+155 −0 src/mgbf/mg_input.f90
+972 −0 src/mgbf/mg_interpolate.f90
+1,394 −0 src/mgbf/mg_intstate.f90
+190 −0 src/mgbf/mg_mppstuff.f90
+936 −0 src/mgbf/mg_parameter.f90
+218 −0 src/mgbf/mg_timers.f90
+499 −0 src/mgbf/mg_transfer.f90
+44 −0 src/mgbf/type_intstat_locpointer.inc
+83 −0 src/mgbf/type_intstat_point2this.inc
+105 −0 src/mgbf/type_parameter_locpointer.inc
+189 −0 src/mgbf/type_parameter_point2this.inc
+2 −3 ush/sub_hera
+2 −2 ush/sub_hercules
+1 −1 ush/sub_jet
+1 −1 ush/sub_orion
2 changes: 1 addition & 1 deletion sorc/gsi_utils.fd
9 changes: 5 additions & 4 deletions sorc/link_workflow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,11 @@ fi
#--link source code directories
#------------------------------
cd "${HOMEgfs}/sorc" || exit 8
if [[ -d ufs_model.fd ]]; then
[[ -d upp.fd ]] && rm -rf upp.fd
${LINK} ufs_model.fd/FV3/upp upp.fd
fi
# TODO: Commenting out until UPP is up-to-date with Rocky-8.
#if [[ -d ufs_model.fd ]]; then
# [[ -d upp.fd ]] && rm -rf upp.fd
# ${LINK} ufs_model.fd/FV3/upp upp.fd
#fi

if [[ -d gsi_enkf.fd ]]; then
[[ -d gsi.fd ]] && rm -rf gsi.fd
Expand Down
2 changes: 1 addition & 1 deletion sorc/ufs_utils.fd
Submodule ufs_utils.fd updated 39 files
+5 −1 CMakeLists.txt
+1 −1 VERSION
+1 −0 docs/main.md
+2 −2 docs/source/chgres_cube.rst
+73 −3 docs/source/ufs_utils.rst
+1 −3 modulefiles/build.hera.gnu.lua
+1 −1 modulefiles/build.hera.intel.lua
+1 −1 modulefiles/build.jet.intel.lua
+1 −1 reg_tests/grid_gen/driver.jet.sh
+4 −6 reg_tests/ice_blend/driver.hera.sh
+3 −3 reg_tests/ice_blend/driver.jet.sh
+9 −2 reg_tests/snow2mdl/driver.hera.sh
+4 −1 sorc/chgres_cube.fd/CMakeLists.txt
+64 −19 sorc/chgres_cube.fd/static_data.F90
+4 −1 sorc/emcsfc_snow2mdl.fd/CMakeLists.txt
+4 −1 sorc/global_cycle.fd/CMakeLists.txt
+5 −0 sorc/orog_mask_tools.fd/CMakeLists.txt
+4 −1 sorc/orog_mask_tools.fd/orog.fd/CMakeLists.txt
+114 −255 sorc/orog_mask_tools.fd/orog.fd/mtnlm7_oclsm.F
+4 −3 sorc/orog_mask_tools.fd/orog.fd/netcdf_io.F90
+8 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/README
+17 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/mask.fd/CMakeLists.txt
+164 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/mask.fd/mask.f90
+20 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/mask.fd/runit.sh
+17 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/ramp.fd/CMakeLists.txt
+164 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/ramp.fd/ramp.f90
+20 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/ramp.fd/runit.sh
+17 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/topo.fd/CMakeLists.txt
+20 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/topo.fd/runit.sh
+157 −0 sorc/orog_mask_tools.fd/orog_netcdf_tools.fd/topo.fd/topo.f90
+6 −1 sorc/weight_gen.fd/CMakeLists.txt
+3 −6 ush/fv3gfs_make_orog.sh
+2 −0 util/gdas_init/driver.hera.sh
+3 −1 util/gdas_init/driver.jet.sh
+3 −1 util/gdas_init/driver.s4.sh
+2 −0 util/gdas_init/driver.wcoss2.sh
+2 −2 util/gdas_init/run_v15.chgres.sh
+2 −2 util/gdas_init/run_v16retro.chgres.sh
+23 −1 util/gdas_init/set_fixed_files.sh
1 change: 1 addition & 0 deletions sorc/upp.fd
Submodule upp.fd added at 15e2a8
2 changes: 1 addition & 1 deletion versions/build.hera.ver
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export stack_intel_ver=2021.5.0
export stack_impi_ver=2021.5.1
export spack_env=gsi-addon-dev
export spack_env=gsi-addon-dev-rocky8
source "${HOMEgfs:-}/versions/build.spack.ver"
export spack_mod_path="/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-${spack_stack_ver}/envs/${spack_env}/install/modulefiles/Core"
2 changes: 1 addition & 1 deletion versions/run.hera.ver
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export stack_intel_ver=2021.5.0
export stack_impi_ver=2021.5.1
export spack_env=gsi-addon-dev
export spack_env=gsi-addon-dev-rocky8

export hpss_ver=hpss
export ncl_ver=6.6.2
Expand Down

0 comments on commit d6be3b5

Please sign in to comment.