1.21.11 support (Mojang NMS) #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.21.11 uses Mojang mappings (see PaperMC/Paper#13388) while all previous versions will continue to use reobf (Spigot mapping). This uses the recommended Mojang mappings while ensuring backwards compatibility with earlier versions of the Spigot server runtime.
aokod
changed the title
prevents earlier modules from being recognized with Mojang NMS
Owner
|
I'll review this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest obstacle in the way of supporting version 1.21.11 (and especially 26.1 onward) is the plugin's use of Spigot mappings (reobfuscation) instead of Mojang's proprietary mapped classes. This is confirmed by PaperMC/Paper#13388 (comment) which states that "[plugins] have to be on mojang mappings for the next release anyway as 26.1 will be on mojang mappings for both spigot and paper."
As @KaspianDev states in #127, the Spigot API is currently what's delaying support for the new version, and so this PR replaces the Spigot NMS with that of Mojang for version 1.21.11. Spigot reobfuscation continues to be used for game versions 1.21.10 and earlier, meaning that backwards compatibility is preserved.