-
Notifications
You must be signed in to change notification settings - Fork 39
Include 'agg_renderer_base.h' explicitly in 'agg_blur.h' #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fwcd Apologies for the delay. I've updated the CI to use Swift 5.4. Could you please rebase your PR to the latest master? |
|
Sure, I'll rebase it. |
|
There seems to be a test failure on Ubuntu which will need some investigation. Since the macOS test are passing I'm merging this. Thanks a lot for your contribution @fwcd ! Really appreciate it. |
|
Thanks for merging @KarthikRIyer! I just pulled from master and building works but swift test is failing with the following errors: Do I need to install AGGRenderer separately in my project directory? |
|
I'm not sure about this error. AGGRenderer is not an objective-C module. I do not have access to a mac to test it out. |
Fixes #127
This PR fixes the build on Swift 5.4, apparently a header didn't get included correctly.