test: assert behaviour, not the scheduler, in three timing-bound tests by MagicalTux · Pull Request #484 · KarpelesLab/teamclaude

MagicalTux · 2026-09-29T02:48:23Z

Three tests failed on a loaded machine because they asserted wall-clock timing rather than what the code does. Each now observes the behaviour it was written for.

config-lock-file: the test of a writer waiting for another process's lock asserted an upper bound on the wait. The holder now keeps the lock until told to release it (a byte on stdin), and the test asserts what matters: the config is unchanged while the lock is held, the write lands on the release, and the bypass warning never fires. The bypass test keeps only its lower bound, on a short budget. The wait budget is now TEAMCLAUDE_CONFIG_LOCK_WAIT_MS (default unchanged at 2000, read per acquisition), which is also the knob a deployment with slow writers wanted; documented in docs/configuration.md.
mcp-tools: the write-queue test polled for a reload against a 5 s deadline. The reload now announces its arrival and the test waits for that event, bounded only by the runner's timeout.
server-listen-error: the 5 s watchdog on a child that must exit after EADDRINUSE was a bound on startup speed; it is 60 s now, a watchdog against a hang and nothing more.

A fourth failure seen in the same run (reload picks up messageThreads → 501 reload not supported) is a different bug — a port race between concurrently running subprocess tests — and gets its own PR.

🤖 Generated with Claude Code

A test that fails on a loaded machine is measuring wall-clock timing rather than what the code does. Three did: - config-lock-file: the writer that waits for another process's lock asserted an upper bound on how long it waited. It now holds the lock until told to release it and asserts what matters: the file is unchanged while held, the write lands on the release, and the bypass warning never fires. The bypass test keeps its lower bound only, on a short budget. The budget is now TEAMCLAUDE_CONFIG_LOCK_WAIT_MS, read per acquisition, which is also the knob a slow deployment wanted. - mcp-tools: the write queue test polled for a reload against a 5 s deadline; the reload now announces its arrival and the test waits for that, bounded by the runner's own timeout. - server-listen-error: the 5 s watchdog on a child that must exit was a bound on startup speed; it is 60 s, a watchdog against a hang only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Thirty-two commits since 1.1.21. Two change routing on an existing config without an opt-in (#480, #481); the rest is opt-in, additive, or display. Behaviour changes #481 an API-key account's 401 is a cooldown, not a permanent `error`: 1 min, then 5, 15 and 60 for every further rejection with no success in between; any 2xx/3xx resets it. The request still fails over and the client never sees the 401. OAuth accounts are unchanged #480 with session distribution on, requests carrying no session id stay within the top priority tier, so a fallback gateway no longer answers Claude Code's bootstrap and connector calls #470 a 200 whose SSE stream reports a provider failure before any output (`server_is_overloaded`, `response.failed`) fails over once, like a status-shaped failure would #465 a reload removes running accounts whose config entry is gone from disk, so `teamclaude remove` from another shell takes effect at once #460 `import` refuses an account whose token upstream has definitively rejected (401/403), even with `--name`; a 5xx or timeout still imports Rename #483 the project is being renamed to TeamRouter (#72). This release accepts the new name everywhere the old one is read and changes nothing an install has on disk: `teamrouter` runs the same CLI, every `TEAMCLAUDE_*` variable is also read as `TEAMROUTER_*` (which wins when both are set), every `/teamclaude/…` control route also answers at `/teamrouter/…`, and `~/.config/teamrouter.json` is used when it exists Features #441 per-account egress proxy (`accounts[].routing`: http, socks4/4a, socks5/5h) for refresh, probes and requests; `login --routing`, `teamclaude routing set/show/clear`, a connection check before it is relied on, and a short hold when the proxy is unreachable #427 `accounts[].allowExtraUsage: true` lets a paid extra-usage account serve once every account is past its threshold, instead of a 429 #466 `accounts[].maxSpend`, a money cap judged against the month-to-date extra-usage spend upstream reports; the TUI shows what an account has billed #436 `autoRedeemResets` spends a free Codex rate-limit reset credit when the Codex pool runs dry (off by default) #482 `advisorEligibility: "strict" | "prefer"`; when the advisor model narrows selection to a subset of the fleet the log says so, and status carries the reading (`advisorNarrowing`) #478 `stripOverageHeaders` drops another org's per-organization billing headers from responses, for a pool spanning several orgs (#476) #471 `quota.unified5hSeenAt` / `unified7dSeenAt` in status: when upstream last stated each shared window #446 client and dimension usage for the last 5h and 24h in status and the dashboard, resumed across restarts #458 #459 #461 the dashboard sets the switch threshold, enables/disables and reprioritizes an account, and has a light theme remembered per browser #464 `l` in the TUI signs an account in `error` in again from the dashboard #457 status records which Codex limit meters each model (`quota.codexModelLimits`) #442 `quotaBarPercent` drops the percentage beside a TUI bar's countdown #451 `stripRequestFields` takes `content.<block type>` to drop content blocks a strict Anthropic-compatible upstream rejects #469 `proxy.mcp` schemas declare their item types, the write audit line records what happened, and the write queue has a depth (#447–#450) Fixes #477 a refused WebSocket handshake whose headers all drop is relayed as a well-formed head instead of a blank line and body bytes #474 two members of one ChatGPT workspace are told apart by user id, so a second `login --codex` no longer replaces the first #469 a Codex Responses stream with no Content-Type is relayed as a stream and booked; thread repair on the global upstream; TUI settings and status gaps; a hint when a local login would have served #463 a Codex row with no session window draws one wide weekly bar Tests #484 #485 #486 the suite asserts behaviour, not the scheduler: wall-clock upper bounds are gone, and subprocess tests spawn the server through `test-helpers/spawn-server.js`, which verifies the server it reached by `server.pid` (new in status) instead of trusting a port Tooling #452 #453 #454 #455 docker workflow actions bumped

MagicalTux merged commit 0165e74 into master Sep 29, 2026
5 checks passed

This was referenced Sep 29, 2026

test: replace wall-clock upper bounds with the behaviour they stood for #485

Merged

test: spawn the server on a port that is verifiably its own #486

Merged

Bump to 1.1.22 #487

Merged

Navigation Menu

Repository navigation

test: assert behaviour, not the scheduler, in three timing-bound tests - #484

test: assert behaviour, not the scheduler, in three timing-bound tests#484
MagicalTux merged 1 commit into
masterfrom
test/deadline-free

MagicalTux commented Sep 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

MagicalTux commented Sep 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant