Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check logs for SEVERE messages as well #289

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Oct 14, 2024

Related to #290

@zakkak zakkak requested a review from Karm October 14, 2024 09:35
Copy link
Owner

@Karm Karm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @zakkak, I like it, we will catch more weird misbehaviors.

Are you planning on updating the whitelist too in this PR?

@zakkak
Copy link
Collaborator Author

zakkak commented Oct 30, 2024

Are you planning on updating the whitelist too in this PR?

Yes, after rebasing it to remove the AWT failures :)

@zakkak zakkak force-pushed the 2024-10-14-add-severe-filter branch from aeae97a to eca91f9 Compare October 30, 2024 19:22
@zakkak
Copy link
Collaborator Author

zakkak commented Oct 30, 2024

It looks like we don't need to whitelist anything for the time being.

Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seams fine.

@Karm Karm merged commit 15047b4 into Karm:master Oct 31, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants